Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore deprecated parameter setters and getters #790

Merged
merged 7 commits into from
Oct 16, 2017
Merged

Restore deprecated parameter setters and getters #790

merged 7 commits into from
Oct 16, 2017

Commits on Oct 16, 2017

  1. set private variable in init 

    This is how the official documentation does it and avoids a number of linter warnings
    @jenshnielsen
    jenshnielsen committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    b52cacb View commit details
    Browse the repository at this point in the history

  2. revert setting parameter via _private value

    @jenshnielsen
    jenshnielsen committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    1a7f963 View commit details
    Browse the repository at this point in the history

  3. restore get/set as deprecated 

    unbreaks some scripts and drivers that may be relying on this
    @jenshnielsen
    jenshnielsen committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    10795b3 View commit details
    Browse the repository at this point in the history

  4. restore meaning of step=0 to no step

    @jenshnielsen
    jenshnielsen committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    7701800 View commit details
    Browse the repository at this point in the history

  5. update tutorial notebook to use non deprecated api

    @jenshnielsen
    jenshnielsen committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    101c3bb View commit details
    Browse the repository at this point in the history

  6. readd deprecated delay kwarg 

    the order is still scrambled but there is not much we can do about that
    @jenshnielsen
    jenshnielsen committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    2865405 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into parameter_restore_deprecated

    @jenshnielsen
    jenshnielsen committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    5ec2ee3 View commit details
    Browse the repository at this point in the history