Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

#2843, #2806 #2857

Merged
merged 10 commits into from
Dec 8, 2016
Merged

#2843, #2806 #2857

merged 10 commits into from
Dec 8, 2016

Conversation

MikhailArkhipov
Copy link
Contributor

#2843 Failure to set AfterHostStarted working directory stops RHost

  • add ACL check on the directory

#2806 Still occasionally get package load failures

  • store provider rather than create workflow when editor instantiates keyboard processor

#2853 Error adding database connection

  • reference signed and versioned binaries from lib

Update System.Collections.Immutable to 1.3.0

@@ -95,5 +97,33 @@ public static class IOExtensions {
}
return Path.DirectorySeparatorChar.ToString();
}

public static bool HasWritePermission(this string path) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the write permission was the problem for that bug. In that case, it was a directory belonging to a different user, so it couldn't even be read.

FWIW, perhaps it's easier to just try to do Directory.GetFiles on it, and catch an exception? If it fails, then it's definitely not usable. I'm not sure it being not writeable would actually cause R to fail though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I wanted stricter check since writing generally assumes reading (in common sense case anyway)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that is the case for Windows ACLs, at least - I just tried, and you can deny read and allow write to the same user at the same time, and it actually enforces it in that manner.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is possible in general case since ACLs may apply to, say, pipes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave writing check method for now in case we need it

@MikhailArkhipov MikhailArkhipov merged commit 3cb209e into microsoft:master Dec 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants