Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include previous value when setting CMAKE_CXX_FLAGS on Linux #224

Open
pabs3 opened this issue Aug 21, 2021 · 0 comments
Open

include previous value when setting CMAKE_CXX_FLAGS on Linux #224

pabs3 opened this issue Aug 21, 2021 · 0 comments

Comments

@pabs3
Copy link

pabs3 commented Aug 21, 2021

On Linux, the CXXFLAGS passed to cmake are not preserved, this is because the main cmake file overwrites CMAKE_CXX_FLAGS instead of appending to it. This does not occur on Windows and the other CMAKE_*_FLAGS variables are all set correctly.

Currently CMAKE_CXX_FLAGS is set like this:

    set (CMAKE_CXX_FLAGS "...")

It should be set like this instead:

    set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ...")
pabs3 added a commit to pabs3/SPTAG that referenced this issue Aug 21, 2021
@pabs3
Preserve existing cmake C++ flags on Linux
3c5754b 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Sep 19, 2021
@pabs3
Preserve existing cmake C++ flags on Linux
3eea4d9 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Nov 3, 2021
@pabs3
Preserve existing cmake C++ flags on Linux
1c551dd 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Nov 5, 2021
@pabs3
Preserve existing cmake C++ flags on Linux
d23a982 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Dec 10, 2021
@pabs3
Preserve existing cmake C++ flags on Linux
1e18991 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Dec 23, 2021
@pabs3
Preserve existing cmake C++ flags on Linux
1e0ced5 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Jan 25, 2022
@pabs3
Preserve existing cmake C++ flags on Linux
b17179a 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Feb 16, 2022
@pabs3
Preserve existing cmake C++ flags on Linux
b43818f 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 23, 2022
@pabs3
Preserve existing cmake C++ flags on Linux
ea18ecf 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Jun 12, 2022
@pabs3
Preserve existing cmake C++ flags on Linux
083cad9 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Jun 26, 2022
@pabs3
Preserve existing cmake C++ flags on Linux
4fed42d 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Jun 26, 2022
@pabs3
Preserve existing cmake C++ flags on Linux
6c00ec8 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Jun 28, 2022
@pabs3
Preserve existing cmake C++ flags on Linux
da1accf 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Feb 6, 2023
@pabs3
Preserve existing cmake C++ flags on Linux
e744f53 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Mar 1, 2023
@pabs3
Preserve existing cmake C++ flags on Linux
688ad89 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Mar 25, 2023
@pabs3
Preserve existing cmake C++ flags on Linux
29df61e 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Preserve existing cmake C++ flags on Linux
d3f57f4 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Preserve existing cmake C++ flags on Linux
5127408 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Preserve existing cmake C++ flags on Linux
2201d09 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Preserve existing cmake C++ flags on Linux
73761b0 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Preserve existing cmake C++ flags on Linux
480b308 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Preserve existing cmake C++ flags on Linux
f950faa 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Preserve existing cmake C++ flags on Linux
69a547e 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Preserve existing cmake C++ flags on Linux
abe8658 
This allows enabling more compile options by passing them to cmake.

Fixes: microsoft#224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pabs3