Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back the missing unique_ptr swap #170

Merged
merged 1 commit into from Oct 11, 2019
Merged

Conversation

BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented Oct 11, 2019

Add back the missing unique_ptr swap damaged by (Microsoft-internal, pre-GitHub commit) f84d346b33eff67c3e5038fbb32342a82abdb4f2

Resolves DevCom-754487 / VSO-1000729

Description

It looks like when I moved around allocator support for std::unique_ptr to fix our many allocator::construct bugs, I accidentally deleted this overload. Everything appeared to continue to work because the default std::swap does the right thing, although less efficiently and instantiating more templates than necessary.

Checklist

If you're unsure about a box, leave it unchecked. A maintainer will help you.

If a box isn't applicable, add an explanation in bold.
For example: (N/A: this is a bugfix, not a feature)

  • I understand README.md. I also understand that acceptance of
    community PRs will be delayed until the test and CI systems are online.
  • If this is a feature addition, that feature has been voted into the
    C++ Working Draft. Bugfix
  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 .
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before CI is online, leave this unchecked for
    initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository and
    the C++ Working Draft as a reference (and any other cited standards).
    If they were derived from a project that's already listed in NOTICE.txt,
    that's fine, but please mention it. If they were derived from any other
    project (including Boost and libc++, which are not yet listed in
    NOTICE.txt), you must mention it here, so we can determine whether the
    license is compatible and what else needs to be done.

…8fbb32342a82abdb4f2

Resolves DevCom-754487 / VSO-1000729
@BillyONeal BillyONeal requested a review from a team as a code owner October 11, 2019 21:15
@BillyONeal BillyONeal merged commit 0d95d86 into microsoft:master Oct 11, 2019
@BillyONeal BillyONeal deleted the swap branch October 11, 2019 21:39
fengjixuchui added a commit to fengjixuchui/STL that referenced this pull request Oct 12, 2019
Add back the missing unique_ptr swap (microsoft#170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants