-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LWG 3158 issue addressed #195
Conversation
Here is an example test case.
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Note on the force push: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect. (And today I learned that a review comment saying /azp run
doesn't do anything, it has to be a separate comment.)
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with test coverage.
Description
Add a conditional explicit to
std::tuple::tuple(std::allocator_arg_t, const Alloc&)
.Fixes issue #69
Checklist
community PRs will be delayed until the test and CI systems are online.
C++ Working Draft.
I believe this is a bugfix, not a feature.
_Ugly
as perhttps://eel.is/c++draft/lex.name#3.1 .
verified by an STL maintainer before CI is online, leave this unchecked for
initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft as a reference (and any other cited standards).
If they were derived from a project that's already listed in NOTICE.txt,
that's fine, but please mention it. If they were derived from any other
project (including Boost and libc++, which are not yet listed in
NOTICE.txt), you must mention it here, so we can determine whether the
license is compatible and what else needs to be done.