Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TODO comments #221

Merged
merged 3 commits into from
Oct 27, 2019
Merged

Remove TODO comments #221

merged 3 commits into from
Oct 27, 2019

Conversation

jpjjulie
Copy link
Contributor

@jpjjulie jpjjulie commented Oct 26, 2019

Description

Checklist

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • I understand README.md. I also understand that acceptance of
    community PRs will be delayed until the test and CI systems are online.
  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before CI is online, leave this unchecked for
    initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository and
    the C++ Working Draft as a reference (and any other cited standards).
    If they were derived from a project that's already listed in NOTICE.txt,
    that's fine, but please mention it. If they were derived from any other
    project (including Boost and libc++, which are not yet listed in
    NOTICE.txt), you must mention it here, so we can determine whether the
    license is compatible and what else needs to be done.

@jpjjulie jpjjulie requested a review from a team as a code owner October 26, 2019 19:09
@msftclas
Copy link

msftclas commented Oct 26, 2019

CLA assistant check
All CLA requirements met.

stl/inc/compare Show resolved Hide resolved
stl/inc/xcharconv_ryu.h Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member

Hmmm... not sure how I feel about the ones from upstream. Won't that make it more difficult to follow upstream changes?

@StephanTLavavej
Copy link
Member

I maintain a massive amount of diffs relative to upstream (notably, making every identifier __ugly and adding bounds checking and fixed notation). These comments are trivial to deal with.

At this time, I haven't documented the process for staying in sync with upstream, but the commits are in https://github.com/StephanTLavavej/ryu/commits/msvc-latest .

@StephanTLavavej StephanTLavavej merged commit 04cf948 into microsoft:master Oct 27, 2019
@StephanTLavavej
Copy link
Member

Thanks for improving the IDE experience for users of the STL, and congrats on your first commit here!

(@CaseyCarter, you approved the Microsoft-internal port of this change, so I went ahead and merged this.)

@CaseyCarter
Copy link
Member

@CaseyCarter, you approved the Microsoft-internal port of this change, so I went ahead and merged this.

Yes, sorry - I thought I had approved this PR when approving the internal port.

fengjixuchui added a commit to fengjixuchui/STL that referenced this pull request Oct 28, 2019
Changed TODO comments to TRANSITION comments (microsoft#221)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants