-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TODO comments #221
Remove TODO comments #221
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hmmm... not sure how I feel about the ones from upstream. Won't that make it more difficult to follow upstream changes? |
I maintain a massive amount of diffs relative to upstream (notably, making every identifier At this time, I haven't documented the process for staying in sync with upstream, but the commits are in https://github.com/StephanTLavavej/ryu/commits/msvc-latest . |
Thanks for improving the IDE experience for users of the STL, and congrats on your first commit here! (@CaseyCarter, you approved the Microsoft-internal port of this change, so I went ahead and merged this.) |
Yes, sorry - I thought I had approved this PR when approving the internal port. |
Changed TODO comments to TRANSITION comments (microsoft#221)
Description
Checklist
If you're unsure about a box, leave it unchecked. A maintainer will help you.
community PRs will be delayed until the test and CI systems are online.
_Ugly
as perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before CI is online, leave this unchecked for
initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft as a reference (and any other cited standards).
If they were derived from a project that's already listed in NOTICE.txt,
that's fine, but please mention it. If they were derived from any other
project (including Boost and libc++, which are not yet listed in
NOTICE.txt), you must mention it here, so we can determine whether the
license is compatible and what else needs to be done.