Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend range of min max optimization #2825

Merged
merged 7 commits into from Jul 1, 2022
Merged

Extend range of min max optimization #2825

merged 7 commits into from Jul 1, 2022

Conversation

AlexGuteniev
Copy link
Contributor

Towards #2803

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner June 26, 2022 08:09
@StephanTLavavej StephanTLavavej added the performance Must go faster label Jun 27, 2022
@StephanTLavavej StephanTLavavej added this to Initial Review in Code Reviews via automation Jun 27, 2022
@StephanTLavavej StephanTLavavej added the ranges C++20/23 ranges label Jun 27, 2022
CaseyCarter
CaseyCarter requested changes Jun 27, 2022
View reviewed changes
stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/algorithm Show resolved Hide resolved
Code Reviews automation moved this from Initial Review to Work In Progress Jun 27, 2022
@barcharcraz barcharcraz self-assigned this Jun 27, 2022
barcharcraz
barcharcraz approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@barcharcraz barcharcraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the additional test coverage this looks good to me

@StephanTLavavej StephanTLavavej moved this from Work In Progress to Initial Review in Code Reviews Jun 28, 2022
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Jun 28, 2022
@CaseyCarter CaseyCarter moved this from Final Review to Ready To Merge in Code Reviews Jun 28, 2022
@StephanTLavavej StephanTLavavej self-assigned this Jun 30, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit e619743 into microsoft:main Jul 1, 2022
Code Reviews automation moved this from Ready To Merge to Done Jul 1, 2022
@StephanTLavavej
Copy link
Member

Thanks for bringing your major performance improvement to more parts of the library! 🚀 🎉 😻

@AlexGuteniev AlexGuteniev deleted the minmax_element_range branch July 1, 2022 04:06
fsb4000 pushed a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
@AlexGuteniev @fsb4000
Extend range of min max optimization (microsoft#2825)
643286e
@StephanTLavavej StephanTLavavej mentioned this pull request Apr 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@barcharcraz barcharcraz barcharcraz approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
performance Must go faster ranges C++20/23 ranges
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AlexGuteniev @StephanTLavavej @CaseyCarter @barcharcraz