yvals_core.h: Consistent diagnostics and warnings

[sam20908]

Fixes #237
Fixed broken PR history of #2969

[strega-nil-ms]

You should also change anything that says "suppress this deprecation" to "suppress this warning".

[StephanTLavavej]

Marking as decision needed for the reasons that I explained here: #237 (comment) (I suspect I made that comment before we created the decision needed label.)

Also, there are occurrences of "acknowledge" outside <yvals_core.h>. If we decide that this should be changed, the occurrences in <hash_map>, <hash_set>, <type_traits>, <experimental/coroutine>, and <experimental/filesystem> should be checked.

[StephanTLavavej]

We talked about this at the weekly maintainer meeting - the consensus was that we should consistently say suppress, and that we should refer to things as warnings or errors but not diagnostics (as that's Standard jargon, not in wide use among programmers).

[StephanTLavavej]

Thanks! Everything in <yvals_core.h> looks good. Searching for all occurrences of "acknowledge" and "diagnostic", I found a few more files that needed to be updated (I previously mentioned some of them):

• Say "suppress this error" for "hard deprecations".
• Say "suppress this error" for the Clang experimental/coroutine message.
  • Drop "and acknowledge that this is unsupported"; this repeats "currently do not support Clang".
• Reword the aligned_storage message.
  • Unify "acknowledge that you understand this message and" and "silence this message and" into "To suppress this error,".
  • Say "confirm" and drop "actually".
• Change "diagnostic" to "error" in the join_view message.

FYI @strega-nil-ms as I pushed these changes after you approved (I believe they all align with what you wanted).

[StephanTLavavej]

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

[StephanTLavavej]

Thanks for making these messages simpler and more consistent! 💬 🎉 😸