Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yvals_core.h: Consistent diagnostics and warnings #2973

Merged
merged 10 commits into from Aug 12, 2022
Merged

yvals_core.h: Consistent diagnostics and warnings #2973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
155fde5
Consistent diagnostics and warnings
sam20908 Jul 30, 2022
f2922be
Suppress is more accurate for these messages
sam20908 Aug 4, 2022
b547a44
More one accurate suppress
sam20908 Aug 4, 2022
b2bc0f8
Use error instead of diagnostic
sam20908 Aug 10, 2022
2d412ac
Use warning instead of deprecation
sam20908 Aug 10, 2022
aaf257a
Say "suppress this error" for "hard deprecations".
StephanTLavavej Aug 11, 2022
87a7630
Say "suppress this error" for the Clang experimental/coroutine message.
StephanTLavavej Aug 11, 2022
3381197
Reword the aligned_storage message.
StephanTLavavej Aug 11, 2022
aa0520d
Change "diagnostic" to "error" in the join_view message.
StephanTLavavej Aug 11, 2022
7db7958
Update clang message in <experimental/coroutine>
CaseyCarter Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 4 additions & 5 deletions stl/inc/experimental/coroutine
View file
Open in desktop
Expand Up @@ -27,14 +27,13 @@ _STL_DISABLE_CLANG_WARNINGS
#undef new

#if defined(__clang__) && !defined(_SILENCE_CLANG_COROUTINE_MESSAGE)
#error The <experimental/coroutine>, <experimental/generator>, and <experimental/resumable> headers currently do not \
support Clang. You can define _SILENCE_CLANG_COROUTINE_MESSAGE to silence this message and acknowledge that this is \
unsupported.
#error The <experimental/coroutine>, <experimental/generator>, and <experimental/resumable> \
headers do not support Clang, but the C++20 <coroutine> header does.
#endif // defined(__clang__) && !defined(_SILENCE_CLANG_COROUTINE_MESSAGE)

#ifdef __cpp_impl_coroutine
#error The <experimental/coroutine> and <experimental/resumable> headers are only supported \
with /await and implement pre-C++20 coroutine support. Use <coroutine> for standard C++20 coroutines.
#error The <experimental/coroutine> and <experimental/resumable> headers are only supported with \
/await and implement pre-C++20 coroutine support. Use <coroutine> for standard C++20 coroutines.
#endif // __cpp_impl_coroutine

// intrinsics used in implementation of coroutine_handle
Expand Down
2 changes: 1 addition & 1 deletion stl/inc/experimental/filesystem
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@ _STL_DISABLE_CLANG_WARNINGS
#ifndef _SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING
#error The <experimental/filesystem> header providing std::experimental::filesystem is deprecated by Microsoft \
and will be REMOVED. It is superseded by the C++17 <filesystem> header providing std::filesystem. \
You can define _SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING to acknowledge that you have received this warning.
You can define _SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING to suppress this error.
#endif // _SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING

#pragma warning(disable : 4365) // conversion from 'type_1' to 'type_2', signed/unsigned mismatch (/Wall)
Expand Down
2 changes: 1 addition & 1 deletion stl/inc/hash_map
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@ _STL_DISABLE_CLANG_WARNINGS

#ifndef _SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS
#error <hash_map> is deprecated and will be REMOVED. Please use <unordered_map>. You can define \
_SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS to acknowledge that you have received this warning.
_SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS to suppress this error.
#endif // _SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS

namespace stdext {
Expand Down
2 changes: 1 addition & 1 deletion stl/inc/hash_set
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@ _STL_DISABLE_CLANG_WARNINGS

#ifndef _SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS
#error <hash_set> is deprecated and will be REMOVED. Please use <unordered_set>. You can define \
_SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS to acknowledge that you have received this warning.
_SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS to suppress this error.
#endif // _SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS

namespace stdext {
Expand Down
2 changes: 1 addition & 1 deletion stl/inc/ranges
View file
Open in desktop
Expand Up @@ -3077,7 +3077,7 @@ namespace ranges {
"We believe that WG21 will be unable to fix this problem without breaking ABI. "
"To minimize breakage when a fix is implemented, "
"we are temporarily disabling potentially problematic cases. "
"You can define _USE_JOIN_VIEW_INPUT_RANGE to suppress this diagnostic, "
"You can define _USE_JOIN_VIEW_INPUT_RANGE to suppress this error, "
"but be aware that you will almost certainly need to recompile "
"when we release a fix.");
#endif // _USE_JOIN_VIEW_INPUT_RANGE
Expand Down
8 changes: 3 additions & 5 deletions stl/inc/type_traits
View file
Open in desktop
Expand Up @@ -1024,11 +1024,9 @@ struct _Aligned<_Len, _Align, double, false> {
"non-conformingly have an alignment of only alignof(max_align_t). VS 2017 15.8 was fixed to "
"handle this correctly, but the fix inherently changes layout and breaks binary compatibility "
"(*only* for uses of aligned_storage with extended alignments). "
"Please define either "
"(1) _ENABLE_EXTENDED_ALIGNED_STORAGE to acknowledge that you understand this message and "
"that you actually want a type with an extended alignment, or "
"(2) _DISABLE_EXTENDED_ALIGNED_STORAGE to silence this message and get the old non-conforming "
"behavior.");
"To suppress this error, please define either "
"(1) _ENABLE_EXTENDED_ALIGNED_STORAGE to confirm that you want a type with an extended alignment, or "
"(2) _DISABLE_EXTENDED_ALIGNED_STORAGE to get the old non-conforming behavior.");
#endif // !_DISABLE_EXTENDED_ALIGNED_STORAGE
using type = _Align_type<max_align_t, _Len>;
#endif // _ENABLE_EXTENDED_ALIGNED_STORAGE
Expand Down