Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable ASAN string annotations #2990

Merged
merged 3 commits into from Aug 4, 2022

Conversation

amyw-msft
Copy link
Member

Disabling string annotations to unblock ASAN testing. Work to re-enable is ongoing.

@amyw-msft amyw-msft requested a review from a team as a code owner August 3, 2022 20:42
@StephanTLavavej StephanTLavavej added bug Something isn't working test Related to test code labels Aug 3, 2022
@StephanTLavavej StephanTLavavej added this to Initial Review in Code Reviews via automation Aug 3, 2022
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in Code Reviews Aug 4, 2022
@StephanTLavavej
Copy link
Member

Internal mirror: MSVC-PR-414948

@amyw-msft amyw-msft merged commit 1a418ba into microsoft:main Aug 4, 2022
Code Reviews automation moved this from Ready To Merge to Done Aug 4, 2022
strega-nil pushed a commit to strega-nil/stl that referenced this pull request Aug 6, 2022
Temporarily disable ASAN string annotations.
fsb4000 pushed a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
Temporarily disable ASAN string annotations.
@doomlaur
Copy link

Thanks for working on the ASAN annotations! 😄 Maybe you are aware of this already, but this feature unfortunately causes issues, as explained here (but also in 64-bit builds): https://developercommunity.visualstudio.com/t/VS2022---Address-sanitizer-on-x86-Debug-/10116361

Just wondering, have the ASAN string annotations been disabled because of this?

@metarutaiga
Copy link

Because it miss null-terminated

#ifdef _INSERT_STRING_ANNOTATION
_Traits::move(_My_data._Bx._Buf, _Arg, _Count);
_Traits::assign(_My_data._Bx._Buf[_Count], _Elem());
#else // ^^^ _INSERT_STRING_ANNOTATION ^^^ // vvv !_INSERT_STRING_ANNOTATION vvv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Related to test code
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants