Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split tests/P1206R7_ranges_to into four parts #3026

Merged
merged 4 commits into from
Aug 12, 2022

Conversation

CaseyCarter
Copy link
Member

,... to reduce resource consumption. The obvious approach here is to split the three big pieces (the sequence_instantiator, mappish_instantiator, and settish_instantiator tests) each into their own tests, leaving behind the three small pieces (test_reservable, test_common_constructible, and test_nested_range).

Fun fact: there are now 50 P1206R7 tests in the std suite.

,... to reduce resource consumption. The obvious approach here is to split the three big pieces (the `sequence_instantiator`, `mappish_instantiator`, and `settish_instantiator` tests) each into their own tests, leaving behind the three small pieces (`test_reservable`, `test_common_constructible`, and `test_nested_range`).

Fun fact: there are now 50 `P1206R7` tests in the `std` suite.
@CaseyCarter CaseyCarter added test Related to test code ranges C++20/23 ranges labels Aug 11, 2022
@CaseyCarter CaseyCarter requested a review from a team as a code owner August 11, 2022 21:05
@CaseyCarter
Copy link
Member Author

I think this was purely code-shifting, so diffing each of the four new tests with the old P1206R7_ranges_to should "line up" the matching chunks and make for quick review.

I did also cleanup the includes a bit, adding <cstddef> for std::size_t but mostly trimming excess - notably <format> and <iostream> were handy during initial development but are no longer used by these tests.

@strega-nil-ms strega-nil-ms self-assigned this Aug 11, 2022
@StephanTLavavej
Copy link
Member

Diffing against the original test was indeed very easy, thanks for avoiding other code movement! I pushed changes to fix a stealth merge conflict and one moved test line that was revealed by the diff.

@StephanTLavavej StephanTLavavej self-assigned this Aug 11, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Copy link
Member

I've pushed a conflict-free merge to resolve the conflict with #3015 (git's "ort" strategy is apparently better than GitHub's strategy, possibly the old "recursive").

@StephanTLavavej StephanTLavavej merged commit a3f2956 into microsoft:main Aug 12, 2022
@StephanTLavavej
Copy link
Member

2️⃣ ➕ 2️⃣

@CaseyCarter CaseyCarter deleted the ranges_four branch August 12, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ranges C++20/23 ranges test Related to test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants