Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null function check for move_only_function assigned from a DLL and issues caused by an unloaded DLL that constructed or assigned an empty move_only_function #3038

Merged
merged 4 commits into from
Aug 18, 2022
Merged

Fix null function check for move_only_function assigned from a DLL and issues caused by an unloaded DLL that constructed or assigned an empty move_only_function #3038

merged 4 commits into from
Aug 18, 2022

Conversation

AlexGuteniev
Copy link
Contributor

Fixes #3037

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner August 17, 2022 07:54
@AlexGuteniev AlexGuteniev changed the title Fix issues caused by an unloaded DLL that constructed or assigned an empty move_only_function Fix null function check for move_only_function assigned from a DLL and issues caused by an unloaded DLL that constructed or assigned an empty move_only_function Aug 17, 2022
@CaseyCarter CaseyCarter added the bug Something isn't working label Aug 17, 2022
@StephanTLavavej StephanTLavavej self-assigned this Aug 17, 2022
StephanTLavavej
StephanTLavavej reviewed Aug 18, 2022
View reviewed changes
stl/inc/functional Outdated Show resolved Hide resolved
stl/inc/functional Outdated Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

Thanks for fixing this bug before ABI lockdown! I pushed extremely minor changes to use auto and improve comment grammar/spelling.

@StephanTLavavej StephanTLavavej removed their assignment Aug 18, 2022
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 18, 2022
Closed
@StephanTLavavej StephanTLavavej self-assigned this Aug 18, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 39b29dd into microsoft:main Aug 18, 2022
@StephanTLavavej
Copy link
Member

Thanks again for fixing this bug before it was trapped in ABI amber for a million years! 🐞 🦕 😹

@AlexGuteniev AlexGuteniev deleted the this_is_i_guess_what_we_call_dll_hell branch August 18, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

std::move_only_function::operator bool doesn't work for DLLs
4 participants
@AlexGuteniev @StephanTLavavej @strega-nil-ms @CaseyCarter