Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmention DevCom-10111923 in test P0088R3_variant #3394

Merged
merged 2 commits into from Feb 11, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Feb 6, 2023

DevCom-10111923 and DevCom-10112408 (mistakenly treated as duplicate of the former) are reported as fixed in 17.4. I've tried to test the relative cases (added in #2971), but the tests still failed.

With some local tests, I'm sure that DevCom-10111923 is fixed in 17.4, but DevCom-10112408 is still not fixed (the posted example still fails to compile).

DevCom-10111923 and DevCom-10112408 are reported to be fixed, let's test relative cases.
@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner February 6, 2023 08:32
@frederick-vs-ja frederick-vs-ja changed the title Enable some formerly buggy visit<R> test cases for MSVC Unmention DevCom-10111923 in test P0088R3_variant Feb 6, 2023
@CaseyCarter CaseyCarter added the test Related to test code label Feb 6, 2023
@CaseyCarter CaseyCarter added this to Initial Review in Code Reviews via automation Feb 6, 2023
@CaseyCarter CaseyCarter moved this from Initial Review to Final Review in Code Reviews Feb 6, 2023
@strega-nil-ms strega-nil-ms moved this from Final Review to Ready To Merge in Code Reviews Feb 6, 2023
@StephanTLavavej StephanTLavavej self-assigned this Feb 10, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 122602d into microsoft:main Feb 11, 2023
Code Reviews automation moved this from Ready To Merge to Done Feb 11, 2023
@StephanTLavavej
Copy link
Member

Thanks for cleaning up these bug citations! 🐞 🧹 😺

@frederick-vs-ja frederick-vs-ja deleted the gh-2971-test-cases branch February 11, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test code
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants