Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unmention DevCom-10111923 in test P0088R3_variant #3394

Merged
merged 2 commits into from Feb 11, 2023
Merged

Unmention DevCom-10111923 in test P0088R3_variant #3394

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c9b1e4
Enable some formerly buggy test cases for MSVC
frederick-vs-ja Feb 6, 2023
f363ddb
Restore skipping as DevCom-10112408 is not yet fixed
frederick-vs-ja Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/std/tests/P0088R3_variant/test.cpp
View file
Open in desktop
Expand Up @@ -7673,10 +7673,10 @@ namespace msvc {
};

using VarTestConv = std::variant<convertible_to_immobile_one, convertible_to_immobile_other>;
#if defined(__clang__) || defined(__EDG__) // TRANSITION, DevCom-10111923 and DevCom-10112408
#if defined(__clang__) || defined(__EDG__) // TRANSITION, DevCom-10112408
assert(std::visit<R>(std::identity{}, VarTestConv{convertible_to_immobile_one{}}).x == 1729);
assert(std::visit<R>(std::identity{}, VarTestConv{convertible_to_immobile_other{}}).x == 1138);
#endif // TRANSITION, DevCom-10111923 and DevCom-10112408
#endif // TRANSITION, DevCom-10112408
auto immobile_converter = [](auto src) -> immobile_data { return src; };
assert(std::visit<R>(immobile_converter, VarTestConv{convertible_to_immobile_one{}}).x == 1729);
assert(std::visit<R>(immobile_converter, VarTestConv{convertible_to_immobile_other{}}).x == 1138);
Expand Down