Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LWG-3833 Remove specialization template<size_t N> struct formatter<const charT[N], charT> #3477

Merged
merged 1 commit into from Feb 23, 2023
Merged

LWG-3833 Remove specialization template<size_t N> struct formatter<const charT[N], charT> #3477

merged 1 commit into from Feb 23, 2023

Conversation

mlemacio
Copy link
Contributor

@mlemacio mlemacio commented Feb 17, 2023 •
edited

Remove specialization template<size_t N> struct formatter<const charT[N], charT>
Fixes #3426

@mlemacio
Implement LWG-3833
384086c 
Remove template specialization
@mlemacio mlemacio requested a review from a team as a code owner February 17, 2023 21:48
@github-actions github-actions bot added this to Initial Review in Code Reviews Feb 17, 2023
@mlemacio mlemacio mentioned this pull request Feb 17, 2023
Closed
@StephanTLavavej StephanTLavavej added LWG Library Working Group issue format C++20/23 format labels Feb 17, 2023
@StephanTLavavej
Copy link
Member

Thanks for the PR! Can you edit your PR description to add "Fixes #3426."? This is special syntax for GitHub that will link the issue to your PR. (It only takes effect in the PR description, not the title, and not later comments where issues can only be "mentioned".)

@mlemacio
Copy link
Contributor Author

Added to PR description

strega-nil-ms
strega-nil-ms approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mlemacio
Copy link
Contributor Author

Yay! Are there any recommended resources on how to get more knowledgeable on the ecosystem so that I may contribute more? I consider myself a fairly seasoned user of C++ but this has been my first foray into open source.

@fsb4000
Copy link
Contributor

fsb4000 commented Feb 18, 2023 •
edited

Are there any recommended resources on how to get more knowledgeable on the ecosystem so that I may contribute more?

You can watch the code reviews and notice what was wrong and don't do that in your PRs: https://www.youtube.com/playlist?list=PLReL099Y5nRffygixwNJhENbYxhuJL6Ei

@mlemacio
Copy link
Contributor Author

mlemacio commented Feb 18, 2023 •
edited

@fsb4000 Just watched my first one in the playlist. Had a good time doing do. Thanks!

@mlemacio
Copy link
Contributor Author

@microsoft-github-policy-service agree

@fsb4000
Copy link
Contributor

fsb4000 commented Feb 18, 2023

Something bad happened.
I think the correct commit is 384086c

CaseyCarter
CaseyCarter requested changes Feb 18, 2023
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that you've force-pushed the changes from your other PR atop this one.

Code Reviews automation moved this from Initial Review to Work In Progress Feb 18, 2023
@mlemacio
Copy link
Contributor Author

Sorry about that, should be fixed.

@CaseyCarter CaseyCarter mentioned this pull request Feb 21, 2023
Closed
@CaseyCarter CaseyCarter moved this from Work In Progress to Ready To Merge in Code Reviews Feb 21, 2023
@StephanTLavavej StephanTLavavej self-assigned this Feb 22, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit be1ac63 into microsoft:main Feb 23, 2023
Code Reviews automation moved this from Ready To Merge to Done Feb 23, 2023
@StephanTLavavej
Copy link
Member

Thanks for implementing this LWG issue resolution, and congratulations on your first microsoft/STL commit! 😻 🚀 🎉

This will ship in VS 2022 17.7 Preview 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
format C++20/23 format LWG Library Working Group issue
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-3833 Remove specialization template<size_t N> struct formatter<const charT[N], charT>
5 participants
@mlemacio @StephanTLavavej @fsb4000 @CaseyCarter @strega-nil-ms