Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LWG-3860 range_common_reference_t is missing #3480

Merged
merged 2 commits into from Feb 23, 2023
Merged

Implement LWG-3860 range_common_reference_t is missing #3480

merged 2 commits into from Feb 23, 2023

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Feb 18, 2023

Fixes #3416

@fsb4000 fsb4000 requested a review from a team as a code owner February 18, 2023 11:47
@github-actions github-actions bot added this to Initial Review in Code Reviews Feb 18, 2023
@fsb4000 @JMazurkiewicz
fix copy-pasta
a79101d 
Co-authored-by: Jakub Mazurkiewicz <mazkuba3@gmail.com>
@CaseyCarter CaseyCarter added LWG Library Working Group issue ranges C++20/23 ranges labels Feb 18, 2023
CaseyCarter
CaseyCarter reviewed Feb 18, 2023
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to make this available in C++20.

@CaseyCarter CaseyCarter moved this from Initial Review to Final Review in Code Reviews Feb 18, 2023
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@CaseyCarter CaseyCarter moved this from Final Review to Ready To Merge in Code Reviews Feb 21, 2023
@StephanTLavavej StephanTLavavej self-assigned this Feb 22, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 7aaa151 into microsoft:main Feb 23, 2023
Code Reviews automation moved this from Ready To Merge to Done Feb 23, 2023
@StephanTLavavej
Copy link
Member

Thanks for finding this alias at the lost&found! 😹 🔍 🎉

@fsb4000 fsb4000 deleted the fix3416 branch February 23, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@JMazurkiewicz JMazurkiewicz JMazurkiewicz approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue ranges C++20/23 ranges
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-3860 range_common_reference_t is missing
4 participants
@fsb4000 @StephanTLavavej @CaseyCarter @JMazurkiewicz