Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<ranges>: Fix ranges::equal for ranges with integer-class range_difference_t #3551

Merged
merged 3 commits into from Mar 13, 2023
Merged

<ranges>: Fix ranges::equal for ranges with integer-class range_difference_t #3551

merged 3 commits into from Mar 13, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

Closes #3550.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner March 9, 2023 00:42
@github-actions github-actions bot added this to Initial Review in Code Reviews Mar 9, 2023
@StephanTLavavej StephanTLavavej added bug Something isn't working ranges C++20/23 ranges labels Mar 9, 2023
@StephanTLavavej
Copy link
Member

I have massively reworked this PR by changing 16.7% of its lines 🤪 😹

Thanks for the fix!

@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Mar 9, 2023
@CaseyCarter CaseyCarter moved this from Final Review to Ready To Merge in Code Reviews Mar 9, 2023
@StephanTLavavej StephanTLavavej self-assigned this Mar 10, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Copy link
Member

I pushed a commit to work around a notorious /clr bug affecting views::iota.

@StephanTLavavej StephanTLavavej merged commit 1e7d460 into microsoft:main Mar 13, 2023
35 checks passed
Code Reviews automation moved this from Ready To Merge to Done Mar 13, 2023
@StephanTLavavej
Copy link
Member

Thanks for finding and fixing this ranges bug! 🐞 🛠️ 😸

@JMazurkiewicz JMazurkiewicz deleted the equal-gh3550 branch March 14, 2023 00:00
@StephanTLavavej StephanTLavavej mentioned this pull request Mar 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working ranges C++20/23 ranges
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<ranges>: ranges::equal does not work for ranges with integer-class range_difference_t
3 participants
@JMazurkiewicz @StephanTLavavej @CaseyCarter