Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update yvals_core.h to April 2023 #3643

Merged
merged 1 commit into from Apr 14, 2023
Merged

Update yvals_core.h to April 2023 #3643

merged 1 commit into from Apr 14, 2023

Conversation

YairBorn
Copy link
Contributor

@YairBorn YairBorn commented Apr 10, 2023 •
edited by StephanTLavavej

Fixed #3611.

@YairBorn YairBorn requested a review from a team as a code owner April 10, 2023 09:12
@github-actions github-actions bot added this to Initial Review in Code Reviews Apr 10, 2023
@YairBorn YairBorn mentioned this pull request Apr 10, 2023
Closed
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Apr 10, 2023
@StephanTLavavej
Copy link
Member

Thanks! Code change looks great, we'll get this merged this week. (We simultaneously merge changes to the GitHub and MSVC-internal repos in a semi-manual process, so we batch up PRs to save time.)

One note - GitHub's close/fix/resolve syntax is very picky. In order to automatically link an issue to a PR, such that merging the PR closes the issue, you need to say one of the magic words followed immediately by the issue number. (And this needs to appear in the PR description, not the PR title nor any later comment.) Accordingly, I have edited your PR description from:

fixed this issue ->https://github.com/microsoft/STL/issues/3611

to:

Fixed #3611.

Now if you look in the column on the right of the PR, you'll see the issue listed under "Successfully merging this pull request may close these issues."

Just something to remember as you open future PRs on GitHub! 😸

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Apr 10, 2023
@strega-nil-ms strega-nil-ms moved this from Final Review to Ready To Merge in Code Reviews Apr 11, 2023
@StephanTLavavej StephanTLavavej self-assigned this Apr 12, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit d939f8c into microsoft:main Apr 14, 2023
37 checks passed
Code Reviews automation moved this from Ready To Merge to Done Apr 14, 2023
@StephanTLavavej
Copy link
Member

Thanks for updating this version macro! ✅ 🎉 🐱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@fsb4000 fsb4000 fsb4000 approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to April 2023
4 participants
@YairBorn @StephanTLavavej @fsb4000 @strega-nil-ms