Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change _MSVC_STL_UPDATE to May 2023 #3680

Merged
merged 1 commit into from May 5, 2023
Merged

Change _MSVC_STL_UPDATE to May 2023 #3680

merged 1 commit into from May 5, 2023

Conversation

ddr533
Copy link
Contributor

@ddr533 ddr533 commented Apr 30, 2023

Fixes #3679

@ddr533 ddr533 requested a review from a team as a code owner April 30, 2023 14:23
@github-actions github-actions bot added this to Initial Review in Code Reviews Apr 30, 2023
@sam20908
Copy link
Contributor

If anything, I would suggest a more indicative title as to what it is changing, e.g. "Change _MSVC_STL_UPDATE to May 2023".

@ddr533 ddr533 changed the title Change current data. Change _MSVC_STL_UPDATE to May 2023 May 1, 2023
@ddr533
Copy link
Contributor Author

ddr533 commented May 1, 2023

If anything, I would suggest a more indicative title as to what it is changing, e.g. "Change _MSVC_STL_UPDATE to May 2023".

Done

@ddr533 ddr533 changed the title Change _MSVC_STL_UPDATE to May 2023 Change _MSVC_STL_UPDATE to May 2023 May 1, 2023
@CaseyCarter CaseyCarter added the enhancement Something can be improved label May 1, 2023
@CaseyCarter CaseyCarter moved this from Initial Review to Final Review in Code Reviews May 1, 2023
@StephanTLavavej StephanTLavavej moved this from Final Review to Ready To Merge in Code Reviews May 1, 2023
@StephanTLavavej StephanTLavavej self-assigned this May 4, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 5404ba9 into microsoft:main May 5, 2023
37 checks passed
Code Reviews automation moved this from Ready To Merge to Done May 5, 2023
@StephanTLavavej
Copy link
Member

Thanks for updating this version macro, and congratulations on your first microsoft/STL commit! 🎉 🚀 😸

This will be the value used for VS 2022 17.7 Preview 2.

@StephanTLavavej StephanTLavavej mentioned this pull request Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@fsb4000 fsb4000 fsb4000 approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to May 2023
5 participants
@ddr533 @sam20908 @StephanTLavavej @CaseyCarter @fsb4000