Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STL.natvis: Simplify visualization for mutex/recursive_mutex #3848

Merged
merged 2 commits into from Aug 3, 2023
Merged

STL.natvis: Simplify visualization for mutex/recursive_mutex #3848

merged 2 commits into from Aug 3, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

The locking_thread_id and ownership_levels can be represented by named members now, so I believe we can simplify its visualization.

I've verified that the outputs are unchanged for std::recursive_mutex with every combination of MSVC/Clang, x64/x86, and Debug/Release.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner July 5, 2023 16:24
@github-actions github-actions bot added this to Initial Review in Code Reviews Jul 5, 2023
strega-nil-ms
strega-nil-ms approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! (it also works on MSVC/ARM64)

@strega-nil-ms strega-nil-ms moved this from Initial Review to Final Review in Code Reviews Jul 5, 2023
@StephanTLavavej StephanTLavavej added the visualizer How the VS debugger displays STL types label Jul 5, 2023
@StephanTLavavej
Copy link
Member

This removes the ability for the new IDE to visualize old-compiled mutexes, but this is sufficiently obscure and the "pick through the representation" trickery was sufficiently horrible that I think this is a net win.

@StephanTLavavej StephanTLavavej moved this from Final Review to Ready To Merge in Code Reviews Jul 5, 2023
@frederick-vs-ja

This comment was marked as resolved.

Sign in to view
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@StephanTLavavej StephanTLavavej added the blocked Something is preventing work on this label Jul 7, 2023
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Blocked in Code Reviews Jul 7, 2023
@StephanTLavavej StephanTLavavej removed the blocked Something is preventing work on this label Jul 21, 2023
@StephanTLavavej StephanTLavavej moved this from Blocked to Work In Progress in Code Reviews Jul 21, 2023
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@StephanTLavavej StephanTLavavej moved this from Work In Progress to Final Review in Code Reviews Jul 21, 2023
@strega-nil-ms strega-nil-ms moved this from Final Review to Ready To Merge in Code Reviews Aug 1, 2023
@strega-nil-ms strega-nil-ms removed their assignment Aug 1, 2023
@StephanTLavavej StephanTLavavej self-assigned this Aug 3, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 9b4a05c into microsoft:main Aug 3, 2023
35 checks passed
Code Reviews automation moved this from Ready To Merge to Done Aug 3, 2023
@StephanTLavavej
Copy link
Member

Thanks for improving these visualizers! 👁️ 👀 👁️‍🗨️

@frederick-vs-ja frederick-vs-ja deleted the mutex-visualizer branch August 3, 2023 23:16
CaseyCarter added a commit to CaseyCarter/STL that referenced this pull request Aug 30, 2023
@CaseyCarter
Revert "STL.natvis: Simplify visualization for mutex/`recursive_m…
d4249c2 
…utex` (microsoft#3848)"

This reverts commit 9b4a05c.
@CaseyCarter CaseyCarter mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
visualizer How the VS debugger displays STL types
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frederick-vs-ja @StephanTLavavej @strega-nil-ms