Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LWG-3749 common_iterator should handle integer-class difference types #4190

Merged
merged 1 commit into from Nov 17, 2023
Merged

Implement LWG-3749 common_iterator should handle integer-class difference types #4190

merged 1 commit into from Nov 17, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #4163.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner November 13, 2023 17:42
@github-actions github-actions bot added this to Initial Review in Code Reviews Nov 13, 2023
@StephanTLavavej StephanTLavavej added LWG Library Working Group issue ranges C++20/23 ranges labels Nov 13, 2023
@StephanTLavavej StephanTLavavej self-assigned this Nov 13, 2023
@CaseyCarter CaseyCarter moved this from Initial Review to Final Review in Code Reviews Nov 13, 2023
@StephanTLavavej StephanTLavavej removed their assignment Nov 13, 2023
@StephanTLavavej StephanTLavavej moved this from Final Review to Ready To Merge in Code Reviews Nov 13, 2023
@StephanTLavavej StephanTLavavej self-assigned this Nov 16, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit d9d2a91 into microsoft:main Nov 17, 2023
37 checks passed
Code Reviews automation moved this from Ready To Merge to Done Nov 17, 2023
@StephanTLavavej
Copy link
Member

😻

@StephanTLavavej StephanTLavavej mentioned this pull request Nov 17, 2023
Merged
@frederick-vs-ja frederick-vs-ja deleted the lwg-3749 branch November 17, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue ranges C++20/23 ranges
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-3749 common_iterator should handle integer-class difference types
3 participants
@frederick-vs-ja @StephanTLavavej @CaseyCarter