Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more unnecessary typenames #4191

Merged
merged 2 commits into from Nov 17, 2023

Conversation

StephanTLavavej
Copy link
Member

Works towards #3718. Might be complete, but I'm not 100% sure.

In addition to finding some occurrences in product code that we previously missed, I audited the test code, especially focusing on 20/23 tests.

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Nov 13, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner November 13, 2023 18:20
@github-actions github-actions bot added this to Initial Review in Code Reviews Nov 13, 2023
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Nov 13, 2023
@StephanTLavavej
Copy link
Member Author

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@CaseyCarter CaseyCarter removed their assignment Nov 16, 2023
@CaseyCarter CaseyCarter moved this from Final Review to Ready To Merge in Code Reviews Nov 16, 2023
@StephanTLavavej
Copy link
Member Author

I've pushed a merge with main to resolve a trivial conflict with #4190 in <iterator>.

@StephanTLavavej StephanTLavavej merged commit 3e84424 into microsoft:main Nov 17, 2023
35 checks passed
Code Reviews automation moved this from Ready To Merge to Done Nov 17, 2023
@StephanTLavavej StephanTLavavej deleted the down-with-typename branch November 17, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants