Remove need for user to specify triplet, and enable ARM and ARM64 build #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…XX_COMPILER_ARCHITECTURE_ID. This is somewhat fragile because it's documented as an internal-to-cmake variable, but FindBoost.cmake has used it 'effectively forever' so I'm not too concerned.
BillyONeal
requested review from
StephanTLavavej,
CaseyCarter and
barcharcraz
StephanTLavavej
approved these changes
Sep 7, 2019
CaseyCarter
approved these changes
Sep 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vcpkg folks responded to our feature request by suggesting use of
CMAKE_CXX_COMPILER_ARCHITECTURE_ID, which avoids the user needing to specify VCPKG_TARGET_TRIPLET on the command line. This will also allow use of our build scripts when the user has provided Boost some other way, instead of only vcpkg.Also checked that the ARM and ARM64 bits function, fixed some failures discovered by doing that, and added those configurations to VS's
CMakeSettings.json.