Implement load(8 bytes) with a 64 bit read on x86 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This depends on compiler support that will first ship in Visual Studio 2019 Update 4, so it's guarded to allow the build to work with current preview releases. Resolves https://developercommunity.visualstudio.com/content/problem/274938/index.html Replays VSO PR 199513, this is the last substantial change I hope to do before we can work wholly in GitHub.
BillyONeal
requested review from
CaseyCarter,
barcharcraz and
StephanTLavavej
Shouldn't this be "Visual Studio 2019 version 16.4"? I I thought we stopped using the "Update N" nomenclature. |
CaseyCarter
approved these changes
Sep 11, 2019
I admittedly am not positive what we're calling all the things now :/. It seems I turn around and they changed it again. Looks like Stephan already fixed it. |
|
Casey's guidance is strictly correct for VS 2017 and VS 2019. I personally omit "version" whenever I can get away with it. |
StephanTLavavej
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on compiler support that will first ship in Visual Studio 2019 16.4, so it's guarded to allow the build to work with current preview releases.
Resolves https://developercommunity.visualstudio.com/content/problem/274938/index.html
Replays VSO PR 199513, this is the last substantial change I hope to do before we can work wholly in GitHub first. (barring fire drills)