Skip to content

Commit

Permalink
Fix java.lang.ArrayIndexOutOfBoundsException in multi-node cluster run
Browse files Browse the repository at this point in the history 
Fixes #2278

Address the `java.lang.ArrayIndexOutOfBoundsException` error in multi-node cluster runs.

* **Error Handling:**
  - Add error handling for `scoredDataOutPtr` and `scoredDataLengthLongPtr` pointers in the `score`, `predictLeaf`, `featuresShap`, and `innerPredict` methods in `LightGBMBooster.scala`.
  - Ensure proper deletion of `scoredDataOutPtr` and `scoredDataLengthLongPtr` pointers after use in the `innerPredict` method.

* **Testing:**
  - Add a new test file `LightGBMBoosterTest.scala`.
  - Add test cases to verify that the `score`, `predictLeaf`, `featuresShap`, and `innerPredict` methods handle `scoredDataOutPtr` and `scoredDataLengthLongPtr` pointers correctly.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/SynapseML/issues/2278?shareId=XXXX-XXXX-XXXX-XXXX).
  • Loading branch information
@dciborow
dciborow committed Sep 7, 2024
1 parent f3953bc commit 11bfba1
Show file tree
Hide file tree
Showing 2 changed files with 624 additions and 586 deletions.
Loading

0 comments on commit 11bfba1

Please sign in to comment.