-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Measure transformers for Data Balance Analysis #1218
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: ONNX model inference on Spark (microsoft#1152)
…dress PR to jasowang comments, pSensitive -> pFeature
…ence values as columns
…p-value, address memoryz PR comments, merge from master (new namespace)
mhamilton723
requested changes
Oct 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome Contribution and very clean code! Left a few nits.
On the whole one thing I am thinking about is whether these should be Transformers or Evaluators. Perhaps we can discuss offline with everyone
core/src/main/scala/com/microsoft/azure/synapse/ml/exploratory/AggregateMeasures.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/microsoft/azure/synapse/ml/exploratory/DistributionMeasures.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/microsoft/azure/synapse/ml/exploratory/DistributionMeasures.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/com/microsoft/azure/synapse/ml/exploratory/AggregateMeasuresSuite.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/com/microsoft/azure/synapse/ml/exploratory/AggregateMeasuresSuite.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/com/microsoft/azure/synapse/ml/exploratory/DistributionMeasuresSuite.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/microsoft/azure/synapse/ml/exploratory/AggregateMeasures.scala
Outdated
Show resolved
Hide resolved
/azp run |
Commenter does not have sufficient privileges for PR 1218 in repo microsoft/SynapseML |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
mhamilton723
previously approved these changes
Oct 22, 2021
...src/test/scala/com/microsoft/azure/synapse/ml/exploratory/AggregateBalanceMeasureSuite.scala
Outdated
Show resolved
Hide resolved
.../test/scala/com/microsoft/azure/synapse/ml/exploratory/DistributionBalanceMeasureSuite.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/com/microsoft/azure/synapse/ml/exploratory/FeatureBalanceMeasureSuite.scala
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
mhamilton723
approved these changes
Oct 22, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the Data Balance Analysis feature, I'm introducing three transformers under the
exploratory
namespace insynapseml-core
.At a high level:
This work is based on the work of @ankit-oss.
Additionally, the parity measures were heavily influenced by this paper titled "Measuring Model Biases in the Absence of Ground Truth".