Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔁: Updated plugins loading workflow to be able to store them o… #325

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fariquelme
Copy link
Contributor

🔁: Updated plugins loading workflow to be able to store them on separate directories

@fariquelme
Copy link
Contributor Author

@microsoft-github-policy-service agree

@liqul liqul requested a review from Jack-Q May 6, 2024 03:03
@liqul
Copy link
Contributor

liqul commented May 6, 2024

Thanks for the contribution.

But we have some concerns with it. I can see it breaking some unit test cases. This might be easy to fix. However, this change makes it incompatible with the existing setting, so there requires an explicit upgrade operation for users who has already been using the code repo. So, the better approach is to support both separated folders and putting files in the plugins folder directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants