TS 4.4 changes document.createTreeWalker to only take three params, which is illegal in IE11 #1068
Comments
|
Do we need something like |
saschanaz
added a commit
to saschanaz/DefinitelyTyped
that referenced
this issue
Jul 17, 2021
createTreeWalker is the first known IE11-only failure reported in microsoft/TypeScript-DOM-lib-generator#1068.
saschanaz
added a commit
to saschanaz/DefinitelyTyped
that referenced
this issue
Jul 17, 2021
createTreeWalker is the first known IE11-only failure reported in microsoft/TypeScript-DOM-lib-generator#1068.
12 tasks
saschanaz
added a commit
to saschanaz/DefinitelyTyped
that referenced
this issue
Jul 17, 2021
createTreeWalker is the first known IE11-only failure reported in microsoft/TypeScript-DOM-lib-generator#1068.
typescript-bot
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this issue
Aug 3, 2021
* Add IE11 types createTreeWalker is the first known IE11-only failure reported in microsoft/TypeScript-DOM-lib-generator#1068. * rename as web-ie11 * fix package error * add version
aomarks
added a commit
to lit/lit
that referenced
this issue
Aug 31, 2021
- Upgrade all package locks. Includes TypeScript 4.3.5 -> 4.4.2. - Typing fixes for TypeScript 4.4.2 (mostly https://devblogs.microsoft.com/typescript/announcing-typescript-4-4/#use-unknown-catch-variables) - Adds `devDependency` on new `@types/web-ie11` package to address microsoft/TypeScript-DOM-lib-generator#1068 - Upgrade `xmldom` to new `@xmldom/xmldom` due to xmldom/xmldom#271 - Pin the localize transform example to TypeScript ~4.3.5 due to rollup/plugins#983 - Add missing `@types/node` dependency to `internal-scripts` (not sure why this wasn't an error before -- maybe the Node types were coming via a transitive dependency which was removed by an upgrade). - Minor `@lit/localize-tools` changes: don't run `build` as part of `test` script, use `@lit/ssr` bare module in test instead of relative path, trivial config file schema change from dependency upgrade.
kevinpschaaf
pushed a commit
to lit/lit-element-starter-ts
that referenced
this issue
Sep 21, 2021
- Upgrade all package locks. Includes TypeScript 4.3.5 -> 4.4.2. - Typing fixes for TypeScript 4.4.2 (mostly https://devblogs.microsoft.com/typescript/announcing-typescript-4-4/#use-unknown-catch-variables) - Adds `devDependency` on new `@types/web-ie11` package to address microsoft/TypeScript-DOM-lib-generator#1068 - Upgrade `xmldom` to new `@xmldom/xmldom` due to xmldom/xmldom#271 - Pin the localize transform example to TypeScript ~4.3.5 due to rollup/plugins#983 - Add missing `@types/node` dependency to `internal-scripts` (not sure why this wasn't an error before -- maybe the Node types were coming via a transitive dependency which was removed by an upgrade). - Minor `@lit/localize-tools` changes: don't run `build` as part of `test` script, use `@lit/ssr` bare module in test instead of relative path, trivial config file schema change from dependency upgrade.
|
Let's consider this as fixed by DefinitelyTyped/DefinitelyTyped#54594. @github-actions close |
|
Closing because @saschanaz is one of the code-owners of this repository. |
AndrewJakubowicz
pushed a commit
to lit/lit-element-starter-js
that referenced
this issue
Dec 8, 2021
- Upgrade all package locks. Includes TypeScript 4.3.5 -> 4.4.2. - Typing fixes for TypeScript 4.4.2 (mostly https://devblogs.microsoft.com/typescript/announcing-typescript-4-4/#use-unknown-catch-variables) - Adds `devDependency` on new `@types/web-ie11` package to address microsoft/TypeScript-DOM-lib-generator#1068 - Upgrade `xmldom` to new `@xmldom/xmldom` due to xmldom/xmldom#271 - Pin the localize transform example to TypeScript ~4.3.5 due to rollup/plugins#983 - Add missing `@types/node` dependency to `internal-scripts` (not sure why this wasn't an error before -- maybe the Node types were coming via a transitive dependency which was removed by an upgrade). - Minor `@lit/localize-tools` changes: don't run `build` as part of `test` script, use `@lit/ssr` bare module in test instead of relative path, trivial config file schema change from dependency upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
lib Update Request
Configuration Check
My compilation target is
ES2016and my lib isthe defaultin the TS 4.4 beta.Missing / Incorrect Definition
document.createTreeWalker was updated to take at most three parameters, where in previous TypeScript versions it would take four. Internet Explorer 11 will throw if the fourth parameter isn't specified.
The fourth parameter is deprecated, but real world code that needs to support older browsers like IE11 must use it.
Sample Code
Real world example: https://github.com/lit/lit/blob/a791514b426b790de2bfa4c78754fb62815e71d4/packages/lit-html/src/lit-html.ts#L396-L401
Documentation Link
https://developer.mozilla.org/en-US/docs/Web/API/Document/createTreeWalker
The text was updated successfully, but these errors were encountered: