-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix update core dependencies #1708
base: main
Are you sure you want to change the base?
Fix update core dependencies #1708
Conversation
This has never been problem for this long, it has been okay for many years. I guess ESLint 9 contains a lot of huge breaking changes? And yes I think it would be better to have a separate job rather than having a temporary workaround. (Edit: I mean, it's not "broken again", it has been broken with the same error for several weeks and I was expecting it would be solved very soon.) |
We can also try 8.0.0-alpha.3 🤔 |
ESLint 9 changed the default configuration format to the new "flat config". So we'd need to migrate to the new format, or throw Indeed, it looks like we'll need an alpha release of |
Never mind, that alpha version still only supports ESLint v8. Support for ESLint v9 is still being worked on in typescript-eslint/typescript-eslint#9002, so we cannot update to v9 at the moment. I'll see if I can migrate us to the flat config format already. That should hopefully make it easier to update to v9 once TypeScript ESLint adds support. |
That should do it. The next workflow run should properly update the dependencies again:
|
But again, should we try only updating "core dependencies" rather than doing a temporary workaround? I just opened #1709 which will let Dependabot to do things better, after that this job won't need to update other deps. (It did mostly because Dependabot had no group update, but now it has.) |
typescript-eslint/typescript-eslint#9002 is still open, that should happen too. |
Yeah, I think I'll wait for TypeScript ESLint to get updated first. |
The "update core dependencies" workflow is broken again, see log:
The problem is that ESLint version 9 has been released, but TypeScript ESLint doesn't support it yet. I worked around it by making
ncu -u
ignoreeslint
for now.That said, perhaps it would be better if this workflow only updated the actual "core dependencies"? npm-check-updates accepts a filter argument, so we could do something like this instead: