Let dependabot to update in group and touch package.json #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems touching dependabot.yml somehow does not trigger the bot. That means I should manually ping @sandersn. |
Comment on lines
+18
to
+21
| eslint: | ||
| patterns: | ||
| - "eslint*" | ||
| - "@typescript-eslint/*" |
There was a problem hiding this comment.
Looking at what will be needed for TypeScript ESLint in the future, we may want to already add @eslint/* too:
Suggested change
| eslint: | |
| patterns: | |
| - "eslint*" | |
| - "@typescript-eslint/*" | |
| eslint: | |
| patterns: | |
| - "eslint*" | |
| - "@eslint/*" | |
| - "@typescript-eslint/*" |
sandersn
approved these changes
May 8, 2024
There was a problem hiding this comment.
Looks good according to my reading of the documentation.
- Maybe add
@eslint/*in a followup PR? - Only slightly related, but I wonder whether exact versions would be safer long-term? But that may not be well-supported by tools like dependabot -- the documentation I read assumes version ranges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.