This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Migrate TSLint to ESLint. Closes #209 #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orta
approved these changes
Jul 15, 2019
|
Looks like tests are after including an |
peterblazejewicz
force-pushed
the
feat/209
branch
from
c115c78
to
509c147
Compare
Yup, thanks! Interesting it worked locally. The PR updated. Let's wait for Travis |
This commit rewrites linting support in the project to be based solely on the ESLint as advised by the TSLint tool authors: https://medium.com/palantir/tslint-in-2019-1a144c2317a9 The migration is based on default, recommended settings for TypeScript in ESLint and is expected to be updated in future to better fit project goals. All references has been updated and replaced with relevant ESLint context: - dependencies migration from TSLint to ESLint - VSCode configuration changes to support ESLint exension - VSCode extensions recommendation changes - `.eslintrc` and `.eslintignore` configuration files added - all error level problems in the source files are covered by this migration Thanks!
peterblazejewicz
force-pushed
the
feat/209
branch
from
509c147
to
af2c813
Compare
|
Cool, nice, ship it when you're happy 👍 |
brittanydrandolph
pushed a commit
that referenced
this pull request
Jun 17, 2022
✨ Migrate TSLint to ESLint. Closes #209
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit rewrites linting support in the project to be based solely
on the ESLint as advised by the TSLint tool authors:
https://medium.com/palantir/tslint-in-2019-1a144c2317a9
The migration is based on default, recommended settings for TypeScript
in ESLint and is expected to be updated in future to better fit project
goals.
All references has been updated and replaced with relevant ESLint
context:
.eslintrcand.eslintignoreconfiguration files addedmigration
This is the output of the
npm run lintscript:Thanks!
/cc @felipesilvati