Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Fix lint warnings #214

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Fix lint warnings #214

merged 1 commit into from
Jul 31, 2019

Conversation

mathiasvr
Copy link
Contributor

  • Disables the rules explicit-function-return-type and no-explicit-any which causes many warnings for the current codebase.
  • Expand linting to include root directory as well

@msftclas
Copy link

msftclas commented Jul 31, 2019

CLA assistant check
All CLA requirements met.

@@ -3,7 +3,6 @@ import compression from "compression"; // compresses requests
import session from "express-session";
import bodyParser from "body-parser";
import lusca from "lusca";
import dotenv from "dotenv";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this an accident?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this was to fix a no-unused-var warning, forgot to mention.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a leftover from f14407d

@orta
Copy link
Contributor

orta commented Jul 31, 2019

👍 cool, works for me then - thanks!

@orta orta merged commit 1bf5836 into microsoft:master Jul 31, 2019
@mathiasvr mathiasvr deleted the lint-fix branch July 31, 2019 17:15
@peterblazejewicz
Copy link
Collaborator

Thanks @mathiasvr!

brittanydrandolph pushed a commit that referenced this pull request Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants