Added GitHub Actions CI Workflow #261
Conversation
|
I'm happy with this 👍 My opinion is that it might not need to be so comprehensive (testing on Mac/window/linux) across 2 node versions? Worth bringing it down to just linux? |
|
|
haha, guess we're in alignment then :D |
|
I wanted to add an OS build matrix to make sure the contributors get alerted by build fails if they attempt to do some OS specific commands in their code / config files. (for example using |
| path: ${{ steps.npm-cache.outputs.dir }} | ||
| key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-node- |
There was a problem hiding this comment.
Is that OK, when ending with dash?
There was a problem hiding this comment.
There was a problem hiding this comment.
ofc, sorry for missing this 🙇
|
Yep 👍 |
Added GitHub Actions CI Workflow
Added a GitHub Actions Workflow with a matrix strategy for Node.js 8.x, 10.x, and 12.x and across Ubuntu, MacOS, and Windows with support for node_modules caching to improve speed.