Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

vscode-eslint v2 settings patch #262

Merged
merged 1 commit into from
Jan 15, 2020
Merged

vscode-eslint v2 settings patch #262

merged 1 commit into from
Jan 15, 2020

Conversation

bmiddha
Copy link
Member

@bmiddha bmiddha commented Jan 3, 2020

dbaeumer.vscode-eslint has deprecated eslint.autoFixOnSave among other changes/improvements in version 2.0.4.

Updated settings.json to fix the following errors:

  • The setting is deprecated. Use editor.codeActionsOnSave instead with a source.fixAll.eslint member.
  • Auto Fix is enabled by default. Use the single string form.
    image

@peterblazejewicz
Copy link
Collaborator

x-ref: https://github.com/microsoft/vscode-eslint/blob/master/README.md#release-notes

peterblazejewicz
peterblazejewicz approved these changes Jan 4, 2020
View reviewed changes
Copy link
Collaborator

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@bmiddha thx for the contribution!

@orta
Copy link
Contributor

orta commented Jan 15, 2020

Looks good to me too

@orta orta merged commit 003f86e into microsoft:master Jan 15, 2020
@bmiddha bmiddha deleted the eslint_autoFixOnSave_deprecated branch January 16, 2020 16:35
brittanydrandolph pushed a commit that referenced this pull request Jun 17, 2022
Merge pull request #262 from bmiddha/eslint_autoFixOnSave_deprecated
5cd07aa 
vscode-eslint v2 settings patch
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@peterblazejewicz peterblazejewicz peterblazejewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bmiddha @peterblazejewicz @orta