Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't see errors #731

Closed
stweedie opened this issue Nov 6, 2019 · 8 comments · Fixed by #735
Closed

Can't see errors #731

stweedie opened this issue Nov 6, 2019 · 8 comments · Fixed by #735
Assignees

Comments

@stweedie
Copy link

stweedie commented Nov 6, 2019

As of a recent patch (presumably this one), the plugin will not show ANY error diagnostics in the file if you do not provide a color in your preferences

preferences

{
  "error_icon": "circle"
}

image

with override

{
  "error_color": "region.redish",
  "error_icon": "circle"
}

image

It appears that the 'default' value is being ignored, which causes there to be no error indicator at all.

@rlugge
Copy link

rlugge commented Nov 6, 2019

THANK you @stweedie , this was crippling my ability to develop. Typescript without IDE type checking is just... ugh. Not getting an error report in the IDE, and only when you go to see the result, is devastating to workflow.

@stweedie
Copy link
Author

stweedie commented Nov 6, 2019

yeah as a workaround, follow these instructions and add the above json snippet (or a different color if you want)

@lorem--ipsum
Copy link

Oh my gosh THANK YOU.

@orta
Copy link
Contributor

orta commented Nov 7, 2019

Anyone know if there is a change we can apply to this plugin to fix this for everyone?

/cc @bertilnilsson

@telmaco
Copy link

telmaco commented Nov 8, 2019

I spent the whole day trying to fix this.
una lastima! :/

Thank you @stweedie!!!

@patrickfatrick
Copy link

I just noticed this the other day and assumed I messed up a config. Thank you so much for the workaround, @stweedie

@DanielRosenwasser
Copy link
Member

#735 has a fix available, should be out soon. Very sorry for the confusion here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
@orta @rlugge @DanielRosenwasser @lorem--ipsum @patrickfatrick @stweedie @telmaco and others