Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose stderr of node process #745

Merged
merged 1 commit into from Jun 8, 2020
Merged

Expose stderr of node process #745

merged 1 commit into from Jun 8, 2020

Conversation

addreas
Copy link
Contributor

@addreas addreas commented May 6, 2020

Would be useful to see errors from the node process if it fails to start. For example when editing the typescript_tsdk setting the plugin might silently fail while the node process says that it was unable to find the specified file.

Would be useful to see errors from the node process if it fails to start. For example when editing the typescript_tsdk setting the plugin might silently fail while the node process says that it was unable to find the specified file.
Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out locally and it seems to work fine, I couldn't crash the node process - but the code is pretty simple

@orta orta merged commit 498d74c into microsoft:master Jun 8, 2020
@orta
Copy link
Contributor

orta commented Jun 8, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants