-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates tmThemes to match latest VSCode colors #959
Conversation
@armanio123 What are the remaining differences? |
TypeScript.YAML-tmTheme
Outdated
@@ -42,8 +46,12 @@ settings: | |||
- scope: entity.name.type.enum.ts | |||
settings: { vsclassificationtype: enum name } | |||
|
|||
- scope: entity.name.function, entity.name.type, meta.template.expression.ts, variable, entity.other.inherited-class.ts | |||
- scope: entity.name.type, meta.template.expression.ts, entity.other.inherited-class.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- scope: entity.name.type, meta.template.expression.ts, entity.other.inherited-class.ts | |
- scope: meta.template.expression.ts, entity.other.inherited-class.ts |
given entity.name.type is classified as type above .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good catch. Fixed.
TypeScript.YAML-tmTheme
Outdated
settings: { vsclassificationtype: identifier } | ||
- scope: variable, meta.definition.variable.name, support.variable, entity.name.variable, constant.other.placeholder | ||
settings: { vsclassificationtype: parameter name } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how come const x = 10
x is classified as parameter name ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed typo. This should be local name
.
This are some of the differences I have identified:
This is the comparison between them: |
Updates typescript and typescriptreact themes to match VSCode colorization.
There are still slight differences between them but this is very close to match all colors.
This is how it looks now on Visual Studio:
Before --> After