Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate 2 file to ko #23

Merged
merged 5 commits into from
Feb 3, 2021
Merged

Translate 2 file to ko #23

merged 5 commits into from
Feb 3, 2021

Conversation

Sanghyuk-CH
Copy link
Contributor

번역 리뷰 요청합니다: @yeonjuan @guyeol @dvlprsh

ref #6

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2021

Thanks for the PR!

This section of the codebase is owned by @bumkeyy, @yeonjuan, and @guyeol - if they write a comment saying "LGTM" then it will be merged.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2021

Translation of plugins.md

display: "Plugins"

oneline: "Specify a list of language service plugins to include."

A list of language service plug-ins to run within the editor.

Language service plug-ins are a way to provide additional information to users based on existing TypeScript files. You can improve existing messages between TypeScript and editors, or provide your own error messages.

Like what:

VS Code automatically include language service pluginsThere's an extension to , tsconfig.jsonYou can run some in the editor without having to define it in .

Generated by 🚫 dangerJS against 3d15063

@orta
Copy link
Contributor

orta commented Feb 1, 2021

The red is my fault, feel free to ignore it and if someone says it is good - I will merge

Copy link
Contributor

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sanghyuk-CH 고생하셨습니다. 제안 남겼습니다 :)


언어 서비스 플러그인은 기존 TypeScript 파일을 기반으로 사용자에게 추가 정보를 제공하는 방법입니다. TypeScript와 편집자 간의 기존 메시지를 개선하거나 자체 오류 메시지를 제공할 수 있습니다.

예를들면:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
예를들면:
예를 들면:

- [typescript-eslint-language-service](https://github.com/Quramy/typescript-eslint-language-service) — 컴파일러 출력 내부에 eslint 오류 메시징 및 수정 기능을 제공합니다.
- [ts-graphql-plugin](https://github.com/Quramy/ts-graphql-plugin) — GraphQL 쿼리 템플릿 문자열 내에서 검증 및 자동 완성을 제공합니다.

VS Code는 [automatically include language service plugins](https://code.visualstudio.com/api/references/contribution-points#contributes.typescriptServerPlugins)에 대한 확장 기능이 있어서, `tsconfig.json`에서 정의 할 필요없이 편집기에서 일부를 실행할 수 있습니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
VS Code는 [automatically include language service plugins](https://code.visualstudio.com/api/references/contribution-points#contributes.typescriptServerPlugins)에 대한 확장 기능이 있어서, `tsconfig.json`에서 정의 할 필요없이 편집기에서 일부를 실행할 수 있습니다.
VS Code는 [automatically include language service plugins](https://code.visualstudio.com/api/references/contribution-points#contributes.typescriptServerPlugins)에 대한 확장 기능이 있어서, `tsconfig.json`에서 정의할 필요 없이 에디터에서 일부를 실행할 수 있습니다.

띄어쓰기 수정해 보았구요. 위에 6번 라인에서 "에디터"라고 번역하셔서 여기서도 에디터로 바꿔봤습니다 :)

Comment on lines 15 to 16
// 코드 샘플을 만들거나 학습할 때 플레이그라운드(playground)에서
// 사용할 필요가 없을 수도 있습니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// 코드 샘플을 만들거나 학습할 때 플레이그라운드(playground)에서
// 사용할 필요가 없을 수도 있습니다.
// 플레이그라운드(playground)에서 코드 샘플을 만들거나 학습할 때는
// 불필요할 수도 있습니다.

조금 자연스럽게 바꿔봤습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

첫 번역 작업이었는데 신경써 주셔서 감사합니다

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다시 수정하였습니다. 확인 부탁 드립니다!!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sanghyuk-CH 고생하셨습니다 :)

Copy link
Contributor

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeonjuan
Copy link
Contributor

yeonjuan commented Feb 3, 2021

LGTM

@github-actions github-actions bot merged commit 4b3b4b6 into microsoft:main Feb 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2021

Merging because @yeonjuan is a code-owner of all the changes - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants