Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate 3 files to ko - out, outDir, outFile #41

Merged
merged 7 commits into from
Feb 26, 2021
Merged

Translate 3 files to ko - out, outDir, outFile #41

merged 7 commits into from
Feb 26, 2021

Conversation

danielsychoo
Copy link
Contributor

en

번역 리뷰 요청합니다: @yeonjuan @guyeol @dvlprsh
ref #6

감사합니다! 😎

1. Feature 3 files
2. Translate 3 files in KO
3. run lint
@ghost
Copy link

ghost commented Feb 18, 2021

CLA assistant check
All CLA requirements met.

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @bumkeyy, @yeonjuan, and @guyeol - if they write a comment saying "LGTM" then it will be merged.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2021

Translation of out.md

display: "Out"

oneline: "Deprecated setting. Use outFile instead."

Instead of outFile Use .

out The option calculates the location of the final file in an unpredictability or inconsistent manner.
This option is retained for backward compatibility only and is not recommended.

Translation of outDir.md

display: "Out Dir"

oneline: "Specify an output folder for all emitted files."

If I specify it by any case, .js (In addition to this, .d.ts, .js.map, etc.) The file is ejected to the specified directory.
The directory structure of the source file is preserved; The calculated route is not what you expect. rootDir Look at .

If I do not specify it, .js The file .ts The file is created in the same directory as where it was created:

$ tsc

example
├── index.js
└── index.ts

As follows: tsconfig.json When you create:

{
  "compilerOptions": {
    "outDir": "dist"
  }
}

With these settings, tscWhen you run , the file dist Go to the folder:

$ tsc

example
├── dist
│   └── index.js
├── index.ts
└── tsconfig.json
Translation of outFile.md

display: "Out File"

oneline: "Specify a file that bundles all outputs into one JavaScript file. If declaration is true, also designates a file that bundles all .d.ts output."

If specified, all Global The (non-module) file is linked to the specified single output file.

Just in case module Two system Or amd If so, all module files are also linked to this file after all global content.

Note: outFile The module Two None Or System, AMD or not Not available.
This option is available for bundle CommonJS or ES6 modules. Not available.

Generated by 🚫 dangerJS against da27f80

Copy link
Contributor

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다:) 몇 가지 제안 남겼습니다.

danielsychoo and others added 6 commits February 26, 2021 20:42
Update suggestions

Co-authored-by: YeonJuan <yeonjuan93@naver.com>
Update suggestions

Co-authored-by: YeonJuan <yeonjuan93@naver.com>
Update suggestions

Co-authored-by: YeonJuan <yeonjuan93@naver.com>
Update suggestions

Co-authored-by: YeonJuan <yeonjuan93@naver.com>
Update suggestions

Co-authored-by: YeonJuan <yeonjuan93@naver.com>
Update suggestions

Co-authored-by: YeonJuan <yeonjuan93@naver.com>
@danielsychoo
Copy link
Contributor Author

@yeonjuan

리뷰 감사합니다. 모두 반영했습니다. :)

@yeonjuan
Copy link
Contributor

LGTM

@github-actions github-actions bot merged commit e7de823 into microsoft:main Feb 26, 2021
@github-actions
Copy link
Contributor

Merging because @yeonjuan is a code-owner of all the changes - thanks!

@danielsychoo danielsychoo deleted the translateKo branch February 28, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants