Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds search to the site #106

Merged
merged 6 commits into from Nov 3, 2019
Merged

Adds search to the site #106

merged 6 commits into from Nov 3, 2019

Conversation

orta
Copy link
Contributor

@orta orta commented Nov 3, 2019

Uses Algolia DocSearch which has become a staple in big OSS projects. It works really well.

Screen Shot 2019-11-03 at 11 07 00 AM

Works fine on mobile also.

To avoid render-blocking networking, the site will download a copy of the JS/CSS during deployment and will work with that. Given the site is deployed every 2/3 days then we'll always be up-to-date, but maybe lag a tiny bit behind. I'd like to do this for the playground too eventually #97

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2019

Messages
📖

Deployed to a PR branch

Generated by 🚫 dangerJS against 96e9ee7

@orta
Copy link
Contributor Author

orta commented Nov 3, 2019

Hrm, looks like some of the automation isn't working like I expected in the PR builds.

@orta
Copy link
Contributor Author

orta commented Nov 3, 2019

TODO:

  • Try get the center nav centered again (maybe make search the same width as the site logo)
  • see what's up with the PR build
  • investigate why iOS has a slight white offset

@orta
Copy link
Contributor Author

orta commented Nov 3, 2019

alright, that looks good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant