Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yarn #2523

Merged
merged 6 commits into from Sep 6, 2022
Merged

Update yarn #2523

merged 6 commits into from Sep 6, 2022

Conversation

andrewbranch
Copy link
Member

No description provided.

@orta
Copy link
Contributor

orta commented Sep 6, 2022

I hit the same thing in #2477 - I think there's something strange going on with webpack ( webpack/webpack#5423 / azu/rc-config-loader#2 seems pretty similar ) but it's hard to see why a yarn upgrade would trigger it

@andrewbranch
Copy link
Member Author

Hm, that’s frustrating. @orta how do you usually update package.json versions of packages in the monorepo? All I was trying to do here was ultimately ship a new patch version of @typescript/vfs, which led me to try yarn version patch, which wasn’t working in that RC.

@orta
Copy link
Contributor

orta commented Sep 6, 2022

If you change the version number manually it will automatically deploy when pushed, it uses pleb on a merge to the v2 branch - this is how I did it

@orta
Copy link
Contributor

orta commented Sep 6, 2022

( I take it back, my update to main was green on that other PR if you want to take it anyway )

@andrewbranch
Copy link
Member Author

I think I fixed it

@andrewbranch
Copy link
Member Author

(playwright is unrelated, but I couldn’t build locally without updating)

@andrewbranch
Copy link
Member Author

Well, playwright update breaks CI. Guess building locally and in Actions is too much to ask.

This reverts commit f96a239.
@andrewbranch andrewbranch merged commit a62e4ac into v2 Sep 6, 2022
@andrewbranch
Copy link
Member Author

Thanks for the help, @orta and @jakebailey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants