Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try the new algolia search #690

Closed
wants to merge 2 commits into from
Closed

Try the new algolia search #690

wants to merge 2 commits into from

Conversation

orta
Copy link
Contributor

@orta orta commented Jun 21, 2020

WIP, but it means I can get the a11y bug on search passed

Screen Shot 2020-06-21 at 2 11 50 PM

@orta
Copy link
Contributor Author

orta commented Jun 21, 2020

The feel is nicer for sure, will try on mobile when I get a PR build made

Trade-offs:

  • This uses a bunch of new react things I've never heard of
  • Introduces CSS vars into the app ( I had to do this eventually anyway for code samples)
  • Used to ship the JS/CSS for search async from the main bundle, it isn't anymore ish

TODO:

  • Need to see how having all this bundled affects DLs
  • Need to verify if it affects running without JS
  • Need to see what it does re:dark mode

@github-actions
Copy link
Contributor

Messages
📖

Deployed to a PR branch - playground tsconfig old handbook

Generated by 🚫 dangerJS against 4f8486e

@orta
Copy link
Contributor Author

orta commented Feb 10, 2021

I've been exploring #928 instead

@orta orta closed this Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant