Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intellisense issues with commit on space and other punctuation #1629

Closed
danquirk opened this issue Jan 9, 2015 · 1 comment · Fixed by #1767
Closed

Intellisense issues with commit on space and other punctuation #1629

danquirk opened this issue Jan 9, 2015 · 1 comment · Fixed by #1767
Assignees
@paulvanbrenk
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Visual Studio Integration with Visual Studio
Milestone
TypeScript 1.5

Comments

@danquirk
Copy link
Member

danquirk commented Jan 9, 2015

VS now commits completion lists on more than tab and enter, including space and a variety of punctuation characters (semicolon, parens, brackets, etc). There are places where we offer completion lists that we shouldn't, or poor completion lists, which were previously visual distractions but now are significant annoyances in the actual typing experience, requiring constantly dismissing completion lists via Esc to type what you intended.

Fat arrow functions
writealambda
Typing a space after the fat arrow argument commits a suggestion that is never correct, and then happens frequently in the body as well.

Type argument declarations
typeargumentcompletion
Tracked here #1428

Destrucuring Assignments
destructuringcompletions
Not supported in the editor yet but will need to work like var declaration completion lists.

There are likely other cases as well but these ones stand out immediately. This also ties into #315 which is asking for a toggle on this behavior. Depending on the fix we use for this behavior we may also have some significant test costs associated with these fixes.
@danquirk danquirk added Bug A bug in TypeScript Visual Studio Integration with Visual Studio labels Jan 9, 2015
@Peter-Juhasz
Copy link

Sometimes an Esc is better than an Enter every single time. :) You are on the right track.

@sophiajt sophiajt added this to the TypeScript 1.4 milestone Jan 12, 2015
@danquirk danquirk mentioned this issue Jan 13, 2015
Closed
@mhegazy mhegazy modified the milestones: TypeScript 1.4, TypeScript 1.4.1, TypeScript 1.4.2, TypeScript 1.5 Jan 14, 2015
@paulvanbrenk paulvanbrenk mentioned this issue Jan 22, 2015
Merged
paulvanbrenk added a commit that referenced this issue Feb 5, 2015
@paulvanbrenk
Merge pull request #1767 from Microsoft/LessAggresiveCompletionList
6184c15 
This adds a builder property to the completion list; this allows us to show the completion list in more places and keep support for alternative completion keys, like space and dot.

Note this required changes on the visual studio side too, so the complete experience won't be available until those are released.

This fixes #1629, #1505, #1428 and negates #315.
@paulvanbrenk paulvanbrenk added the Fixed A PR has been merged for this issue label Feb 5, 2015
@DanielRosenwasser DanielRosenwasser mentioned this issue Mar 4, 2015
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@paulvanbrenk paulvanbrenk

Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Visual Studio Integration with Visual Studio
Projects
None yet
Milestone
TypeScript 1.5
Development

Successfully merging a pull request may close this issue.

Less aggresive completion list microsoft/TypeScript
5 participants
@sophiajt @paulvanbrenk @danquirk @mhegazy @Peter-Juhasz