Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS Server fatal error: Cannot read property 'flags' of undefined #46587

Closed
nandorojo opened this issue Oct 29, 2021 · 4 comments · Fixed by #46973
Closed

TS Server fatal error: Cannot read property 'flags' of undefined #46587

nandorojo opened this issue Oct 29, 2021 · 4 comments · Fixed by #46973
Assignees
@weswigham
Labels
Bug A bug in TypeScript Crash For flagging bugs which are compiler or service crashes or unclean exits, rather than bad output Fix Available A PR has been opened for this issue VS Code Priority Critical issues that VS Code needs fixed in the current TypeScript milestone
Milestone
TypeScript 4.5.3

Comments

@nandorojo
Copy link

Issue Type: Bug

❗️❗️❗️ Please fill in the sections below to help us diagnose the issue ❗️❗️❗️

TypeScript Version: 4.5.0-dev.20211028

Steps to reproduce crash
1.
2.
3.

TS Server Log
❗️Server logging disabled. To help us fix crashes like this, please enable logging by setting:

"typescript.tsserver.log": "verbose"

After enabling this setting, future crash reports will include the server log.

TS Server Error Stack
Server: semantic

TypeError: Cannot read property 'flags' of undefined
    at getPropertyOfObjectType (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:56925:22)
    at getPropertyOfType (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:57585:24)
    at resolveESModuleSymbol (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:49731:54)
    at getTargetOfNamespaceImport (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:48933:28)
    at getTargetOfAliasDeclaration (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:49167:28)
    at resolveAlias (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:49212:30)
    at getSymbol (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:47770:38)
    at resolveNameHelper (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:48062:34)
    at resolveName (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:48045:20)
    at resolveEntityName (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:49384:42)
    at resolveEntityName (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:49392:33)
    at getSymbolOfPartOfRightHandSideOfImportEquals (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:49344:24)
    at getTargetOfImportEqualsDeclaration (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:48796:28)
    at getTargetOfAliasDeclaration (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:49163:28)
    at resolveAlias (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:49212:30)
    at resolveSymbol (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:49202:67)
    at mergeSymbol (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:47556:42)
    at /Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:47671:47
    at Map.forEach (<anonymous>)
    at mergeSymbolTable (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:47669:20)
    at mergeSymbol (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:47580:21)
    at /Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:47671:47
    at Map.forEach (<anonymous>)
    at mergeSymbolTable (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:47669:20)
    at mergeModuleAugmentation (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:47685:17)
    at initializeTypeChecker (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:84884:25)
    at Object.createTypeChecker (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:47327:9)
    at Object.getTypeChecker (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:114201:79)
    at synchronizeHostData (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:159447:21)
    at Proxy.getProgram (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:159568:13)
    at ConfiguredProject.Project.updateGraphWorker (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:164578:53)
    at ConfiguredProject.Project.updateGraph (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:164507:42)
    at ConfiguredProject.updateGraph (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:165500:63)
    at ProjectService.createLoadAndUpdateConfiguredProject (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:167224:25)
    at ProjectService.assignProjectToOpenedScriptInfo (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:168307:44)
    at /Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:168647:97
    at Object.flatMap (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:522:25)
    at ProjectService.applyChangesInOpenFiles (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:168647:41)
    at Session.handlers.ts.Map.ts.getEntries._a.<computed> (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:169805:46)
    at /Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:171738:88
    at IOSession.Session.executeWithRequestId (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:171729:28)
    at IOSession.Session.executeCommand (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:171738:33)
    at IOSession.Session.onMessage (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:171764:35)
    at Interface.<anonymous> (/Users/fernandorojo/.vscode/extensions/ms-vscode.vscode-typescript-next-4.5.20211028/node_modules/typescript/lib/tsserver.js:174369:31)
    at Interface.emit (events.js:315:20)
    at Interface._onLine (readline.js:337:10)
    at Interface._normalWrite (readline.js:482:12)
    at Socket.ondata (readline.js:194:10)
    at Socket.emit (events.js:315:20)
    at addChunk (internal/streams/readable.js:309:12)
    at readableAddChunk (internal/streams/readable.js:284:9)
    at Socket.Readable.push (internal/streams/readable.js:223:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:188:23)

VS Code version: Code 1.61.2 (6cba118ac49a1b88332f312a8f67186f7f3c1643, 2021-10-19T15:49:28.381Z)
OS version: Darwin x64 20.3.0
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 6, 4, 3
Memory (System) 64.00GB (0.41GB free)
Process Argv --crash-reporter-id 3c85877a-7b27-4764-80da-510a866ec58a
Screen Reader yes
VM 0%
Extensions (20)
Extension Author (truncated) Version
vscode-color ans 0.4.5
vscode-apollo apo 1.19.7
vscode-eslint dba 2.2.2
gitlens eam 11.6.1
EditorConfig Edi 0.16.4
vscode-npm-script eg2 0.3.23
prettier-vscode esb 9.0.0
codespaces Git 1.3.3
copilot Git 1.6.3533
todo-tree Gru 0.0.214
vscode-env Iro 0.1.0
vscode-typescript-next ms- 4.5.20211028
color-highlight nau 2.5.0
material-icon-theme PKi 4.10.0
cobalt9 pyd 1.4.1
typescript-mono-repo-import-helper q 0.0.6
synthwave-vscode Rob 0.1.10
vscode-wakatime Wak 17.1.0
fig wit 0.0.5
material-theme zhu 3.13.2

(2 theme extensions excluded)

A/B Experiments 
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30384386
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
vsccppwtct:30382698
bridge0708:30335490
pygetstartedt3:30385195
dockerwalkthru:30377721
bridge0723:30353136
pythonrunftest32:30373476
pythonf5test824:30373475
javagetstartedc:30364665
pythonvspyt187:30373474
vsqsis200cf:30386380
vsaa593cf:30376535
vssld246cf:30386378
@mjbvz mjbvz transferred this issue from microsoft/vscode Oct 29, 2021
@mjbvz
Copy link
Contributor

mjbvz commented Oct 29, 2021

Similar call stack to #45874 but still happening in the latest TS nightly

@mjbvz mjbvz removed their assignment Oct 29, 2021
@andrewbranch
Copy link
Member

Unlike #45874, this doesn't go through a code path that's new to 4.5, so is likely not a recent regression.

@andrewbranch andrewbranch added Bug A bug in TypeScript Crash For flagging bugs which are compiler or service crashes or unclean exits, rather than bad output labels Oct 29, 2021
@andrewbranch andrewbranch added this to the TypeScript 4.6.0 milestone Oct 29, 2021
This was referenced Nov 5, 2021
Closed
Closed
Closed
@mjbvz mjbvz mentioned this issue Nov 17, 2021
Closed
@mjbvz mjbvz added the VS Code Priority Critical issues that VS Code needs fixed in the current TypeScript milestone label Nov 18, 2021
This was referenced Nov 18, 2021
Closed
Closed
Closed
@evanpurkhiser evanpurkhiser mentioned this issue Nov 30, 2021
Merged
@scttcper
Copy link

scttcper commented Nov 30, 2021 •
edited

I think i'm running into this with https://github.com/getsentry/sentry on typescript v4.5.2 We're likely going to revert the TS upgrade, can check out this commit getsentry/sentry@22f4131

vscode info

Version: 1.62.3
Commit: ccbaa2d27e38e5afa3e5c21c1c7bef4657064247
Date: 2021-11-17T07:59:13.865Z (1 wk ago)
Electron: 13.5.2
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 20.6.0

the ts server logs

Info 3092 [16:51:44.430] -----------------------------------------------
Info 3093 [16:51:44.495] FileWatcher:: Added:: WatchInfo: /users/scooper/work/sentry/package.json 250 undefined WatchType: package.json file
Info 3094 [16:51:44.575] Starting updateGraphWorker: Project: /dev/null/autoImportProviderProject1*
Info 3095 [16:51:44.579] DirectoryWatcher:: Added:: WatchInfo: /Users/scooper/work/sentry/node_modules 1 undefined Project: /dev/null/autoImportProviderProject1* WatchType: Failed Lookup Locations
Info 3096 [16:51:44.579] Elapsed:: 0.12090003490447998ms DirectoryWatcher:: Added:: WatchInfo: /Users/scooper/work/sentry/node_modules 1 undefined Project: /dev/null/autoImportProviderProject1* WatchType: Failed Lookup Locations
Err 3235  [16:30:06.514] Exception on executing command {"seq":2,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"/Users/scooper/work/sentry/static/app/views/organizationGroupDetails/actions/index.tsx",
....contents of file here...

this is the file https://github.com/getsentry/sentry/blob/master/static/app/views/organizationGroupDetails/actions/index.tsx

TS Server Error Stack
Server: semantic

TypeError: Cannot read property 'flags' of undefined
    at getPropertyOfObjectType (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:57005:22)
    at getPropertyOfType (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:57665:24)
    at resolveESModuleSymbol (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:49811:54)
    at getTargetOfNamespaceImport (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:48996:28)
    at getTargetOfAliasDeclaration (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:49230:28)
    at resolveAlias (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:49275:30)
    at getSymbol (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:47833:38)
    at resolveNameHelper (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:48125:34)
    at resolveName (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:48108:20)
    at resolveEntityName (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:49447:42)
    at getTargetOfAliasLikeExpression (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:49204:29)
    at getTargetOfExportAssignment (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:49193:28)
    at getTargetOfAliasDeclaration (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:49240:28)
    at resolveAlias (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:49275:30)
    at resolveSymbol (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:49265:67)
    at resolveExternalModuleSymbol (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:49757:36)
    at getTargetOfNamespaceExportDeclaration (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:49180:28)
    at getTargetOfAliasDeclaration (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:49242:28)
    at resolveAlias (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:49275:30)
    at tryResolveAlias (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:49291:24)
    at getCandidateName (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:72927:33)
    at Object.getSpellingSuggestion (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:1873:33)
    at getSpellingSuggestionForName (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:72917:23)
    at /Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:72858:24
    at resolveNameHelper (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:48416:30)
    at getSuggestedSymbolForNonexistentSymbol (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:72840:26)
    at resolveNameHelper (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:48438:42)
    at resolveName (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:48108:20)
    at getGlobalSymbol (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:58878:20)
    at getGlobalTypeSymbol (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:58860:20)
    at getGlobalType (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:58881:26)
    at initializeTypeChecker (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:85034:52)
    at Object.createTypeChecker (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:47390:9)
    at Object.getTypeChecker (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:114385:79)
    at synchronizeHostData (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:159863:21)
    at Object.getProgram (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:159984:13)
    at AutoImportProviderProject.Project.updateGraphWorker (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:164998:53)
    at AutoImportProviderProject.Project.updateGraph (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:164927:42)
    at AutoImportProviderProject.updateGraph (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:165772:70)
    at Object.updateProjectIfDirty (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:166409:45)
    at ConfiguredProject.Project.getPackageJsonAutoImportProvider (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:165547:32)
    at ConfiguredProject.Project.updateGraph (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:164965:26)
    at ConfiguredProject.updateGraph (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:165920:63)
    at ProjectService.createLoadAndUpdateConfiguredProject (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:167644:25)
    at ProjectService.assignProjectToOpenedScriptInfo (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:168727:44)
    at /Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:169067:97
    at Object.flatMap (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:522:25)
    at ProjectService.applyChangesInOpenFiles (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:169067:41)
    at Session.handlers.ts.Map.ts.getEntries._a.<computed> (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:170225:46)
    at /Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:172158:88
    at IOSession.Session.executeWithRequestId (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:172149:28)
    at IOSession.Session.executeCommand (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:172158:33)
    at IOSession.Session.onMessage (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:172184:35)
    at Interface.<anonymous> (/Users/scooper/work/sentry/node_modules/typescript/lib/tsserver.js:174789:31)
    at Interface.emit (events.js:315:20)
    at Interface._onLine (readline.js:337:10)
    at Interface._normalWrite (readline.js:482:12)
    at Socket.ondata (readline.js:194:10)
    at Socket.emit (events.js:315:20)
    at addChunk (internal/streams/readable.js:309:12)
    at readableAddChunk (internal/streams/readable.js:284:9)
    at Socket.Readable.push (internal/streams/readable.js:223:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:188:23)

@Frikki Frikki mentioned this issue Dec 1, 2021
Closed
@andrewbranch
Copy link
Member

Yes, that repros for me—thank you @scttcper! 🙌

@andrewbranch andrewbranch mentioned this issue Dec 1, 2021
Merged
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Dec 1, 2021
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weswigham weswigham

Labels
Bug A bug in TypeScript Crash For flagging bugs which are compiler or service crashes or unclean exits, rather than bad output Fix Available A PR has been opened for this issue VS Code Priority Critical issues that VS Code needs fixed in the current TypeScript milestone
Projects
None yet
Milestone
TypeScript 4.5.3
Development

Successfully merging a pull request may close this issue.

Fix checker initialization crash andrewbranch/TypeScript
7 participants
@DanielRosenwasser @scttcper @weswigham @andrewbranch @mjbvz @nandorojo @typescript-bot