Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow untyped imports #11889

Merged
2 commits merged into from
Oct 27, 2016
Merged

Allow untyped imports #11889

2 commits merged into from
Oct 27, 2016

Conversation

ghost
Copy link

@ghost ghost commented Oct 27, 2016

Fixes #11106
Replaces #11446
Made easier by #11704. No longer has to touch moduleNameResolver.ts.

Copy link
Contributor

@mhegazy mhegazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With changes to the error message

@@ -2869,6 +2869,10 @@
"category": "Error",
"code": 6143
},
"A package for '{0}' was found at '{1}', but is untyped. Because '--noImplicitAny' is enabled, this package must have a declaration.": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about something more consistent with the rest of the the --noImplicitAny error message, e.g.: Could not find a declaration file for module '{0}'. All imports implicitly have type 'any'.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about: "Could not find a declaration file for module '{0}'. '{1}' implicitly has an 'any' type."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -2869,6 +2869,10 @@
"category": "Error",
"code": 6143
},
"A package for '{0}' was found at '{1}', but is untyped. Because '--noImplicitAny' is enabled, this package must have a declaration.": {
"category": "Error",
"code": 6144
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this error code in the 7000 along with the other --noImplicitAnyErrors

@ghost ghost merged commit a143f97 into master Oct 27, 2016
@ghost ghost deleted the untyped_imports branch October 27, 2016 18:32
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants