Split Iterator into Iterator and IterableIterator in es6.d.ts #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -230,22 +230,22 @@ interface ArrayLike<T> { | |||
|
|
|||
| interface Array<T> { | |||
| /** Iterator */ | |||
| [Symbol.iterator] (): Iterator<T>; | |||
| [Symbol.iterator](): IterableIterator<T>; | |||
There was a problem hiding this comment.
Interesting. It returns something htat is both an iterator, and something you can get an iterator off of?
There was a problem hiding this comment.
Yes, all the built-in ES6 iterators are like that.
| } | ||
|
|
||
| interface Iterable<T> { | ||
| [Symbol.iterator](): Iterator<T>; | ||
| } | ||
|
|
||
| interface IterableIterator<T> extends Iterable<T>, Iterator<T> { } |
There was a problem hiding this comment.
I need to fix this because it's not deeply iterable, so it won't work if you do:
var iter: IterableIterator<any>;
iter[Symbol.iterator]()[Symbol.iterator]();The type IterableIterator needs to be recursive for this to work.
JsonFreeman
added a commit
that referenced
this pull request
Feb 23, 2015
Split Iterator into Iterator and IterableIterator in es6.d.ts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the ES6 iterators are themselves iterable, namely they have a Symbol.iterator that returns an iterator. However, a user could define their own iterator and associated iterable, where the iterator does not have this method. To convey this, we need to use IterableIterator in es6.d.ts, but still leave Iterator so that user defined iterators can work.