Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type checking 'for...of' in ES3/5 #2308

Merged
merged 9 commits into from
Mar 12, 2015
Merged

Type checking 'for...of' in ES3/5 #2308

merged 9 commits into from
Mar 12, 2015

Conversation

JsonFreeman
Copy link
Contributor

A 'for...of' statement in ES5 can take an array, a string, a union of arrays, or a union of arrays and string.

A 'for...of' statement in ES3 can take an array or a union of arrays.

@JsonFreeman
Copy link
Contributor Author

My last commit is entitled "Rebaseline tests that will be affected by #2308". I meant #2309.

@@ -8777,16 +8781,11 @@ module ts {
}

function checkForOfStatement(node: ForOfStatement): void {
if (languageVersion < ScriptTarget.ES6) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@JsonFreeman JsonFreeman mentioned this pull request Mar 12, 2015
4 tasks
@yuit
Copy link
Contributor

yuit commented Mar 12, 2015

👍

JsonFreeman added a commit that referenced this pull request Mar 12, 2015
Type checking 'for...of' in ES3/5
@JsonFreeman JsonFreeman merged commit be4ff97 into master Mar 12, 2015
@JsonFreeman JsonFreeman deleted the for-ofES5 branch March 12, 2015 23:04
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants