-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant 'reduce' overloads #25455
Conversation
Well.. with the removed overload there is no contextual type for the initial value parameter... @rbuckton, @DanielRosenwasser and @weswigham thoughts? |
The contextual type would be incorrect anyway in the case that Edit: Shouldn't inference be able to pick up |
I did come up with a test case that's broken by this, see the bottom of |
@mhegazy @sandersn @rbuckton @DanielRosenwasser @weswigham Could you review? |
1 similar comment
@mhegazy @sandersn @rbuckton @DanielRosenwasser @weswigham Could you review? |
I am still concerned about the valid patterns that will be errors with this change. |
@andy-ms let's get this up to date and then see what the RWC run turns up |
@typescript-bot test this |
Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at ab17070. You can monitor the build here. It should now contribute to this PR's status checks. |
Nontrivial RWC breaks occurred |
Fixes #25454