Remove JSDocTag#atToken #28376
Merged
Remove JSDocTag#atToken #28376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ghost
requested a review
from 
sandersn
approved these changes
Nov 6, 2018
|
@andy-ms agree with this decision. Maybe the breaking changes should be updated though? https://github.com/Microsoft/TypeScript/wiki/API-Breaking-Changes (honestly, doubt this is affecting anything other than my tests) Also, should this token be returned when calling |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't really have a good reason for adding these in the parser. We don't typically add non-optional tokens to the parse tree, preferring to do so in services if necessary (see
function createChildreninservices.ts).