Skip to content

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Nov 6, 2018

Fixes #28331

  • handle JSDocTag and JSDocClassTag
  • visit atToken and tagName in existing tags' handling
  • visiting children of JSDocTypeLiteral didn't return early if callback returned truthy value
  • fix codefix for deleting unused identifier

There are still some test failures. All of them have to do with completions in JS files. I don't know how to debug this. It seems like the tagName is treated like an declaration somewhere in the binder or checker (I tried returning early in bindWorker if passed a tagName but that didn't fix the failures...

Tagging @Andy-MS for some guidance on how to fix the remaining test failures

@ghost
Copy link

ghost commented Nov 6, 2018

@ajafff Please take a look at #28376 which will conflict with this.

@ajafff
Copy link
Contributor Author

ajafff commented Nov 6, 2018

@Andy-MS that's fine, I'll update this PR after that other one is merged.

There's still the need for the other changes I made. And there's still the question of how to fix the tests

@ghost
Copy link

ghost commented Nov 6, 2018

OK, please merge from master then I'll look at the tests.

@ghost
Copy link

ghost commented Nov 7, 2018

Made a PR to fix the tests: ajafff#1

@ghost ghost requested a review from sandersn November 7, 2018 16:56
@sandersn sandersn self-assigned this Nov 15, 2018
@sandersn sandersn merged commit 1ad7b0f into microsoft:master Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSDocTag - Nodes on properties do not have parent set when setParentNodes is true
2 participants