forEachToken: correctly handle JSDocTag #28369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28331
atToken
andtagName
in existing tags' handlingThere are still some test failures. All of them have to do with completions in JS files. I don't know how to debug this. It seems like the
tagName
is treated like an declaration somewhere in the binder or checker (I tried returning early inbindWorker
if passed a tagName but that didn't fix the failures...Tagging @Andy-MS for some guidance on how to fix the remaining test failures